Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many small parks and nature_reserves labeled as pois at zoom 10 #1609

Closed
nvkelso opened this issue Sep 24, 2018 · 5 comments
Closed

Many small parks and nature_reserves labeled as pois at zoom 10 #1609

nvkelso opened this issue Sep 24, 2018 · 5 comments
Assignees
Milestone

Comments

@nvkelso
Copy link
Member

nvkelso commented Sep 24, 2018

10/37.5331/-482.0698

image

Too small, icon covers it up completely, more appropriate for zoom 12:

image

Big enough for icon + polygon to show, but really show at 11:

image

@nvkelso nvkelso added this to the v1.6.0 milestone Sep 25, 2018
@nvkelso nvkelso changed the title Many small parks labeld as pois at zoom 10 Many small parks and nature_reserves labeled as pois at zoom 10 Dec 13, 2018
@nvkelso
Copy link
Member Author

nvkelso commented Dec 13, 2018

Seems to be related to:

  - filter:
      any:
        leisure: park
        landuse: park
        boundary: national_park
    min_zoom: { min: [ { max: [ 9, { sum: [ { col: zoom }, 2 ] }, *tier2_min_zoom ] }, 14 ] }
    output:
      <<: *output_properties
      kind: park
      tier: 2

Which uses:

  - &tier2_min_zoom
    lookup:
      key: { col: way_area }
      op: '>='
      table:
        - [ 4, 1000000000 ]
        - [ 5, 1000000000 ]
        - [ 6,  150000000 ]
        - [ 7,  100,000,000 ]
        - [ 8,   10,000,000 ]   # 15,396,834 san bruno at zoom 10
        - [ 9,    5,000,000 ]   #4,451,500 alum rock park at zoom 11
        - [ 10,   1,000,000 ]    # 3,807,010 ed lavin park at zoom 12
                                           # same for John McClaren at 2,311,825 to zoom 12
        - [ 11,    500,000 ]     #    627,235 mount sutro at zoom 13
                                           # same for Glen Park Canyon at 415,605 to zoom 13
        - [ 12,    250,000 ]
        - [ 13,    100,000 ]
        - [ 14,     50000 ]
        - [ 15,      2000 ]
      default: 16

Maybe to:

  - &tier2_min_zoom_small_parks
    lookup:
      key: { col: way_area }
      op: '>='
      table:
        - [ 8,   160000000 ]
        - [ 9,    40000000 ]
        - [ 10,   10000000 ]
        - [ 11,    4000000 ]
        - [ 12,    2000000 ]
        - [ 13,    200000 ]
        - [ 14,     100000 ]
        - [ 15,      10000 ]
      default: 16

Which allows for smaller national parks to show up (good), but then smaller general parks should NOT show up, so split off a different tier breaks just for this filter? Starting at zoom 8 seems consistent with OSM.org styling, too.

Also affecting nature_reserve:

@nvkelso
Copy link
Member Author

nvkelso commented Dec 13, 2018

Related to #1633.

@nvkelso
Copy link
Member Author

nvkelso commented Dec 21, 2018

See San Francisco!

14/37.7820/-122.4493

image

@zerebubuth
Copy link
Member

The only problem with the zoom mapping above is that:

Since Buena Vista is bigger, although not by much, it doesn't seem right to have it come in at min_zoom 14, while Bernal Heights comes in earlier at min_zoom 13.

For the moment, in #1752, I've put them both at 13.

@nvkelso
Copy link
Member Author

nvkelso commented Jan 23, 2019

QA verified.

@nvkelso nvkelso closed this as completed Jan 23, 2019
@ghost ghost removed the send to staging label Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants