-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Water layer are too big at zoom 8 (zoom 7 at 512 tile size) #1477
Comments
Looks like
To match roads: |
And in boundary calculation would explain the missing water lines: |
Does this explain why there are also significantly more road geometries
though?
…On Tue, Feb 13, 2018 at 3:56 PM, Nathaniel V. KELSO < ***@***.***> wrote:
Looks like simplify_start: 8 should be set (instead of 9):
- https://github.com/tilezen/vector-datasource/blob/v1.4.3/
queries.yaml#L144
- https://github.com/tilezen/vector-datasource/blob/v1.4.3/
queries.yaml#L159
To match roads:
- https://github.com/tilezen/vector-datasource/blob/v1.4.3/
queries.yaml#L201
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1477 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABBXdgS9SfbYeRCZIsqphfYvApBAvRIks5tUfcKgaJpZM4SEYrJ>
.
|
Looking at number of water layer features, I think it's because the Comparing the following two tiles:
The number of named water features is essentially the same at 68 or 69, and the remaining delta is 79 with the 2dd min_zoom in nextzen and only 7 count in the mapzen version with the int min_zoom. But the feature count difference doesn't seem to affect total file size in GeoJSON format as both zoom 8 JSON files are 2.9 mb (compared to the huge file size difference at zoom 7). Perhaps we should clip the min_zoom precision to 1dd (eg But this doesn't explain why there are more roads layer features in Nextzen as the min_zoom there is almost always an int (for other YAML related reasons). Showing Nextzen tile having multiple unnamed features: While Mapzen they were all dissolved to single features per kind and zoom (which was always 9, an error that was fixed). |
For roads layer... it looks like the road features between new/old have the same geometry simplification, but I do see that feature count delta. Some of the delta is due to less feature merging (~120 more features with IDs that aren't merged)... but that doesn't account for the other 300 which don't have an ID implying they have been merged but to more total features than before. Looking just at file size of the roads layer as GeoJSON, the Nextzen tile is 1.5 mb versus 1.3 mb Mapzen so it does add up. Further research is needed. |
The issue seems to be that when we added the For the tile 512/all/7/37/48, I see the following feature counts for different values of
And the same for the
Dropping the |
For dropping water names, here's what Walkabout style does (after a year of tweaking so I think it's fine to just copy server side): https://github.com/tangrams/walkabout-style/blob/gh-pages/walkabout-style.yaml#L1258-L1279
This is after the areas are already throttled generally in https://github.com/tangrams/walkabout-style/blob/gh-pages/walkabout-style.yaml#L1068-L1089:
Probably the order of operations is important to drop the features BEFORE generating the water boundary lines. |
The above could probably be simplified to "pixel" areas. Tangram JS now has that facility but we never migrated the code... and vector-datasource has a generic pixel area... the above numbers are just for water features. |
For the areas: New: Old: For the labels: For @iandees: New: Old: |
tl;dr
1.1
instead of1.11
.[ ] roads layer drop properties at low zooms forConsider dropping access=yes and related tags #1331surface
(add surface tag to roads #1197) andaccess
(add access tag to roads, fixes #1273 #1328) tags to the roads. EG we forgot to drop them at low zooms like we do for other tags.===
We did change the NE to OSM switchover in #1359.
So it's expected the feature count be different...
But it seems there are to many features / they have too many names, and their geometries aren't simplified.
At zoom 7 at 512 px tile size in Nextzen build (showing no geom simplification):
Compared to Mapzen build using Natural Earth source (using default NE shapes that are already generalized):
At zoom 8 at 512 px tile size in Nextzen (with generalization):
Compared with zoom 7 at 512 px tile size in Nextzen (no generalization):
/cc @bcamper
The text was updated successfully, but these errors were encountered: