Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide early military #1623

Closed
nvkelso opened this issue Sep 24, 2018 · 5 comments
Closed

Hide early military #1623

nvkelso opened this issue Sep 24, 2018 · 5 comments
Assignees
@zerebubuth
Labels
priority low send to staging
Milestone
v1.7.0

Comments

@nvkelso
Copy link
Member

nvkelso commented Sep 24, 2018 

            # hide based on kind and area filters
            military-early:
                filter:
                    kind: [military]
                    any:
                        # show labels for smaller landuse areas at higher zooms
                        - { $zoom: [8], area: { max: 50000000 } }
                draw:
                    mapzen_icon_library:
                        visible: false
@nvkelso nvkelso added this to the v1.6.0 milestone Sep 25, 2018
@nvkelso
Copy link
Member Author

nvkelso commented Sep 28, 2018

Another one where the icon completely covers the feature at zoom 9, shouldn't show up until zoom 11:

image

@nvkelso
Copy link
Member Author

nvkelso commented Dec 13, 2018

https://www.openstreetmap.org/way/44018189#map=11/38.2479/-122.7766

@nvkelso
Copy link
Member Author

nvkelso commented Dec 13, 2018

Looks like the area breaks in #1609 would solve this problem.

@nvkelso nvkelso modified the milestones: v1.6.0, v1.6.1 Dec 14, 2018
@zerebubuth zerebubuth mentioned this issue Dec 28, 2018
Merged
@ghost ghost assigned zerebubuth Dec 28, 2018
@ghost ghost added the in review label Dec 28, 2018
@nvkelso
Copy link
Member Author

nvkelso commented Jan 11, 2019

Also verify against this view of London / southern England:

image

@nvkelso
Copy link
Member Author

nvkelso commented Jan 23, 2019

QA verified.

@nvkelso nvkelso closed this as completed Jan 23, 2019
@ghost ghost removed the in review label Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zerebubuth zerebubuth

Labels
priority low send to staging
Projects
None yet
Milestone
v1.7.0
Development

No branches or pull requests
2 participants
@zerebubuth @nvkelso