Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demote some early landcover down a few zooms #1794

Closed
nvkelso opened this issue Jan 16, 2019 · 5 comments
Closed

Demote some early landcover down a few zooms #1794

nvkelso opened this issue Jan 16, 2019 · 5 comments
Assignees
@zerebubuth
Labels
layer-landuse qa bug fix send to staging
Milestone
v1.7.0

Comments

@nvkelso
Copy link
Member

nvkelso commented Jan 16, 2019 •
edited
Loading

  • What did you see? Some landuse polygons are rediculously early, which bloats tile size and makes merging harder. Connects with ☂ Reduce landuse layer size at mid-zooms #1721.
  • What did you expect to see? Only shown at relevant zooms.
  • What map location are you having problems with? Global!
  • Screenshot? Props for animated gifs.

Jump to suggested fixes »
@nvkelso nvkelso added this to the v1.7.0 milestone Jan 16, 2019
@nvkelso
Copy link
Member Author

nvkelso commented Jan 16, 2019 •
edited
Loading

Table from @zerebubuth, showing cumulative landcover layer features per kind, per zoom:

kind 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17
national_park 436 436 591 591 663 1230 1433 2023 2277 2595 2842 3112 3730 5091 5091
battlefield 2 2 4 4 4 15 22 47 64 97 119 143 208 436 436
nature_reserve   1470 1470 4005 4846 13325 17729 33136 41763 50877 62749 71571 99968 106675 106675
park   642 642 1658 1922 4457 6193 16064 26243 44641 89994 145287 609038 813963 813963
protected_area   299 299 609 669 1292 1671 2865 3540 4273 5273 6012 8566 9447 9447
forest   179 179 376 446 1359 1940 296179 487838 660059 968297 1309198 3213533 3769716 3769716
residential       53 109 8517 26403 197933 368297 600812 1068240 1578688 4140345 5018540 5018540
glacier           6165 9074 19391 25045 31542 35301 38317 42862 43309 43309
military           1235 1936 5392 8405 13615 17881 21933 38337 43599 43599
aerodrome           730 1768 5523 7407 9940 11547 12858 14272 14341 14341
airfield           91 152 277 311 381 424 478 610 638 638
university           42 170 1748 3297 6178 8756 11806 29219 38065 38065
naval_base           7 19 66 80 117 136 162 234 260 260
college           2 6 328 1019 2527 4466 7706 24973 30892 30892
natural_wood           2 2 402540 593411 853092 1366909 1930589 4490279 5313790 5313790
meadow             1238810 1981172 2338033 2443745 2474874 2485761 2490480 2494451 2494451
wetland             1142815 1558187 1731765 1783583 1801321 1808799 1810314 1810730 1810730
scrub             542431 1006896 1507472 1866881 2014425 2058067 2068759 2071254 2071254
grass             524864 1066101 1685746 2227358 2618789 2778781 2819983 2830746 2830746
grassland             194300 332362 450498 515729 542915 549834 550906 551150 551150
vineyard             127112 239953 320974 346126 348642 349111 349337 349588 349588
bare_rock             113641 181027 265229 329360 352702 363598 367333 369643 369643
heath             102413 151878 186773 205743 212426 213795 214138 214268 214268
quarry             80661 99200 107718 111126 112912 113995 114665 114757 114757
scree             36330 62216 88152 107659 119050 121942 122248 122351 122351
sand             19816 30999 42486 64586 141120 167518 169202 169447 169447
apron             11362 20097 26005 27871 28335 28416 28417 28419 28419
recreation_track             10248 31837 45225 51111 52453 52694 52738 52744 52744
caravan_site             6971 9587 10998 11548 11930 11971 11973 11974 11974
shingle             6952 12860 17195 19147 19977 20300 20369 20372 20372
village_green             6693 19936 40498 62630 79627 87188 88821 89003 89003
dam             6683 15200 22492 26119 27722 28271 28409 28538 28538
mud             5416 7648 9510 10566 10996 11117 11161 11166 11166
prison             4748 6112 6968 7331 7454 7493 7534 7535 7535
runway             3874 5424 5773 5857 5882 5890 5892 5894 5894
rock             2396 4311 6404 8430 10534 12308 12783 12937 12937
water_park             2256 4147 5317 6092 6474 6601 6617 6621 6621
desert             1632 1968 2086 2109 2112 2112 2112 2112 2112
range             1297 1693 1947 2099 2130 2132 2132 2132 2132
land             907 2346 4435 5352 5473 5486 5494 5495 5495
dog_park             777 2848 5692 7446 7917 8039 8080 8082 8082
fort             734 1308 2108 2456 2586 2644 2655 2656 2656
fuel             676 6983 28070 87838 123641 127390 127583 127589 127589
taxiway             672 1487 2446 2929 3049 3075 3075 3075 3075
tree_row             664 1538 2710 3550 3953 4072 4116 4142 4142
picnic_site             561 1804 4035 6441 9268 11255 11955 12016 12016
danger_area             502 626 712 762 790 809 809 809 809
footway             332 3000 12125 26357 39183 47804 49845 50233 50233
enclosure             282 458 754 995 1067 1087 1089 1089 1089
hedge             226 1228 4061 8460 14518 21289 24322 25363 25363
cinema             224 1809 5175 7745 7989 8032 8039 8041 8041
animal             204 731 2068 3197 3904 4094 4110 4112 4112
theatre             190 2354 8628 13888 15271 15476 15494 15495 15495
stone             136 270 486 732 1067 1448 2117 2504 2504
library             126 2063 11206 21210 24053 24339 24365 24372 24372
petting_zoo             113 250 349 405 419 421 421 421 421
natural_park             30 45 68 78 82 83 83 83 83
summer_toboggan             22 29 35 44 50 54 54 55 55
trail_riding_station             20 36 50 88 113 133 143 144 144
roller_coaster             11 72 129 182 203 205 206 206 206
amusement_ride             5 20 72 198 346 372 374 405 405
water_slide             3 18 58 118 199 236 247 249 249
aviary             2 9 42 86 120 141 143 143 143
farmland               493527 785707 1160337 1842450 2446733 4229849 4609002 4609002
industrial               25212 52919 115018 185990 272373 557510 593730 593730
orchard               17075 41260 73936 178359 280570 586078 677615 677615
golf_course               10910 20198 27008 29949 32316 36943 37737 37737
farm               2179 4240 6821 11489 14934 20941 21258 21258
beach               2133 4823 8426 21706 36025 82533 108543 108543
commercial               1974 5341 15694 30835 55170 196614 225932 225932
cemetery               840 2522 9241 21773 47379 289117 326142 326142
winter_sports               763 873 961 1036 1083 1194 1205 1205
railway               744 1816 4942 8882 13927 31075 34376 34376
generator               701 1320 2893 5096 8534 27285 203033 203033
retail               599 2497 9958 21548 39167 142270 168474 168474
plant               571 1026 1644 2210 2770 5805 7822 7822
recreation_ground               492 1206 3866 8891 16939 54077 68062 68062
sports_centre               329 875 3117 8315 18289 96968 131324 131324
wastewater_plant               219 581 1751 3633 6687 28259 41037 41037
zoo               168 352 727 1055 1400 2611 3210 3210
hospital               161 782 3827 9505 16802 50420 66753 66753
theme_park               139 449 788 1833 2578 3827 4318 4318
plant_nursery               136 572 1443 5904 11229 19744 22024 22024
works               120 345 1126 2518 5067 50094 90866 90866
natural_forest               46 56 71 117 157 404 462 462
substation               42 292 1834 5061 11671 115880 281863 281863
stadium               37 115 369 1250 5049 36096 40936 40936
cutline               37 68 198 269 344 602 647 647
grave_yard               29 105 476 1442 3663 47822 61933 61933
water_works               27 79 261 597 1143 5760 12839 12839
wood               26 45 72 117 165 412 492 492
resort               11 30 68 152 196 283 320 320
dike               4 9 27 37 43 56 64 64
bridge               2 3 40 147 533 17665 52257 52257
breakwater               1 11 34 104 274 6248 12790 12790
winery               1 2 5 9 13 20 42 42
service_area                 6614 6955 7134 7213 7238 7241 7241
rest_area                 4550 5194 5497 5626 5686 5686 5686
pier                 927 3732 11059 25789 43413 57183 57183
harbour                 717 918 1039 1100 1130 1141 1141
port                 125 139 150 158 160 160 160
container_terminal                 17 17 17 17 17 17 17
carousel                 7 109 286 313 316 316 316
ferry_terminal                 3 4 4 4 4 4 4
port_terminal                 2 3 3 3 3 3 3
groyne                 1 5 22 72 2064 6567 6567
tower                 1 2 8 18 1195 38902 38902
aquarium                 1 1 11 33 213 339 339
wildlife_park                 1 1 1 1 1 1 1
allotments                   21291 62360 86034 173497 233934 233934
city_wall                   2667 2667 2667 2667 2667 2667
school                   1483 32450 86787 356569 525219 525219
attraction                   787 2311 3497 10320 36106 36106
garden                   681 3298 6461 63239 463260 463260
common                   447 1852 3501 20598 55731 55731
pitch                   198 2808 9147 495872 1388598 1388598
place_of_worship                   46 592 1826 26783 568617 568617
playground                   5 123 383 26998 339506 339506
pedestrian                   3 117 522 24653 149931 149931
artwork                   1 10 25 141 4290 4290
camp_site                     29574 29828 29850 29851 29851
maze                     5 11 61 130 130
wilderness_hut                     3 5 16 1906 1906
urban                     2 3 3 3 3
rural                     1 1 1 1 1
parking                       17163 557848 2641382 2641382
power_line                       650 650 650 650
retaining_wall                         2126 2126 2126
boatyard                         1919 1919 1919
shipyard                         5 5 5
snow_fence                         2 2 2
fence                           53863 53863
wall                           32589 32589
kerb                           5405 5405
embankment                           5071 5071
ditch                           712 712
quay                           348 348
gate                           323 323
guard_rail                           39 39
wharf                           33 33
cutting                           1 1
power_minor_line                             92

@nvkelso
Copy link
Member Author

nvkelso commented Jan 16, 2019

Same in graph form:

image

@nvkelso nvkelso mentioned this issue Jan 16, 2019
Closed
@nvkelso
Copy link
Member Author

nvkelso commented Jan 16, 2019 •
edited
Loading

Suggest changing the min_zoom on the following ~50 kinds to generally show later, but in a couple cases show earlier.

kind 13 17 nvk_note
forest 968297 3769716 show at z9+ instead of z10+; US National Forests at low zooms still fine.
natural_wood 1366909 5313790 show at z9+ instead of z10+; suspect the 2 shown at 8 are miss-tagged; and they should all start at zoom 9
residential 1068240 5018540 show at z9+ only
dam 27722 28538 show at z11+ only
prison 7454 7535 show at z11+ only
fort 2586 2656 show at z11+ only
range 2130 2132 show at z11+ only
danger_area 790 809 show at z11+ only
sports_centre 8315 131324 show at z12+ only
recreation_ground 8891 68062 show at z12+ only
recreation_track 52453 52744 show at z12+ only
wastewater_plant 3633 41037 show at z12+ only
caravan_site 11930 11974 show at z12+ only
aquarium 11 339 show at z12+ only
petting_zoo 419 421 show at z13+ only (we only show zoo starting at 10!)
playground 123 339506 show at z13+ only
substation 5061 281863 show at z13+ only
allotments 62360 233934 show at z13+ only
pedestrian 117 149931 show at z13+ only
fuel 123641 127589 show at z13+ only
pier 11059 57183 show at z13+ only
bridge 147 52257 show at z13+ only
footway 39183 50233 show at z13+ only
tower 8 38902 show at z13+ only
apron 28335 28419 show at z13+ only
hedge 14518 25363 show at z13+ only
library 24053 24372 show at z13+ only
theatre 15271 15495 show at z13+ only
breakwater 104 12790 show at z13+ only
picnic_site 9268 12016 show at z13+ only
dog_park 7917 8082 show at z13+ only
cinema 7989 8041 show at z13+ only
water_park 6474 6621 show at z13+ only
harbour 1039 1141 show at z13+ only
groyne 22 6567 show at z13+ only
runway 5882 5894 show at z13+ only
tree_row 3953 4142 show at z13+ only
animal 3904 4112 show at z13+ only
taxiway 3049 3075 show at z13+ only
enclosure 1067 1089 show at z13+ only
cutline 269 647 show at z13+ only
trail_riding_station 113 144 show at z13+ only
aviary 120 143 show at z13+ only
dike 37 64 show at z13+ only
summer_toboggan 50 55 show at z13+ only
winery 9 42 show at z13+ only
amusement_ride 346 405 show at z15+ only
carousel 286 316 show at z15+ only
water_slide 199 249 show at z15+ only
roller_coaster 203 206 show at z15+ only
camp_site 29574 29851 surprised this isn't area graded

@zerebubuth zerebubuth mentioned this issue Jan 22, 2019
Merged
@ghost ghost assigned zerebubuth Jan 22, 2019
@ghost ghost added the in review label Jan 22, 2019
@zerebubuth zerebubuth mentioned this issue Jan 22, 2019
Merged
@nvkelso
Copy link
Member Author

nvkelso commented Feb 4, 2019

It looks like these changes are showing up, but sometimes the POI shows up well before it's AOI now, so let's make that consistent.

For example: danger_area was demoted AOI to z11+, but it's POI still shows at z9.

z9 POI
image

z11 AOI
image

This was referenced Feb 4, 2019
Closed
Merged
@nvkelso
Copy link
Member Author

nvkelso commented Feb 14, 2019

QA verified.

@nvkelso nvkelso closed this as completed Feb 14, 2019
@ghost ghost removed the in review label Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zerebubuth zerebubuth

Labels
layer-landuse qa bug fix send to staging
Projects
None yet
Milestone
v1.7.0
Development

No branches or pull requests
2 participants
@zerebubuth @nvkelso