Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For buildings, add root_id = id #2092

Closed
tgrigsby-sc opened this issue Jul 5, 2022 · 1 comment
Closed

For buildings, add root_id = id #2092

tgrigsby-sc opened this issue Jul 5, 2022 · 1 comment
Milestone
v1.9.0

Comments

@tgrigsby-sc
Copy link
Contributor

For performance on the rendering side for buildings, it'd be nice to set the root_id equal to its id. This saves us from having to check the kind before determining whether to look at root_id or id.
@tgrigsby-sc tgrigsby-sc mentioned this issue Jul 5, 2022
Merged
2 tasks
@nvkelso
Copy link
Member

nvkelso commented Jul 7, 2022

Fixed via #2093

@nvkelso nvkelso closed this as completed Jul 7, 2022
@nvkelso nvkelso added this to the v1.9.0 milestone Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.0
Development

No branches or pull requests
2 participants
@nvkelso @tgrigsby-sc