Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travisg/20220630 add root id to buildings #2093

Merged
merged 3 commits into from
Jul 5, 2022
Merged

Travisg/20220630 add root id to buildings #2093

merged 3 commits into from
Jul 5, 2022

Conversation

tgrigsby-sc
Copy link
Contributor

Addresses #2092 . Adds a root_id equal to the id to buildings to help rendering performance.

  • Update tests
  • Update docs

@tgrigsby-sc tgrigsby-sc requested a review from bcamper July 5, 2022 20:49
bcamper
bcamper approved these changes Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@bcamper bcamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tgrigsby-sc tgrigsby-sc merged commit 19e0d99 into master Jul 5, 2022
@nvkelso nvkelso mentioned this pull request Jul 7, 2022
Closed
@peitili peitili mentioned this pull request Jul 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcamper bcamper bcamper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgrigsby-sc @bcamper