Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests for v1.4 upstream data changes #1267

Merged
merged 8 commits into from
Jun 6, 2017
Merged

fix tests for v1.4 upstream data changes #1267

merged 8 commits into from
Jun 6, 2017

Conversation

nvkelso
Copy link
Member

@nvkelso nvkelso commented Jun 5, 2017 •
edited
Loading

Fixes #1262.

  • Update tests

@nvkelso nvkelso changed the title WIP: fix tests for v1.4 upstream data changes fix tests for v1.4 upstream data changes Jun 6, 2017
@nvkelso nvkelso requested a review from zerebubuth June 6, 2017 05:27
@nvkelso
Copy link
Member Author

nvkelso commented Jun 6, 2017

CirlceCI is happy now, ready for review.

zerebubuth
zerebubuth approved these changes Jun 6, 2017
View reviewed changes
Copy link
Member

@zerebubuth zerebubuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nvkelso nvkelso merged commit 1a38e4c into master Jun 6, 2017
@nvkelso nvkelso deleted the nvkelso/tests-fix-for-v1.4-upstream-data branch June 6, 2017 16:18
@nvkelso nvkelso removed the in review label Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerebubuth zerebubuth zerebubuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvkelso @zerebubuth