Add amenity=* POIs from OpenStreetMap Carto #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of tilezen#1425 and sets up the parts of code to place the other amenities in.
pnorman
force-pushed
the
1425_amenity_poi
branch
from
9df3c92 to
5cd4398
Compare
nvkelso
reviewed
Dec 21, 2017
| @@ -678,13 +678,13 @@ To resolve inconsistency in data tagging in OpenStreetMap we normalize several o | |||
| * `operator`: Who actually runs the bike share station, eg: "NYC Bike Share". | |||
| * `ref`: The reference of this rental station, if one is available. | |||
|
|
|||
| #### POI properties (only on `kind:bicycle_parking`): | |||
| #### POI properties (only on `kind:bicycle_parking` and `kind:motorcycle_parking`): | |||
There was a problem hiding this comment.
Should these properties apply to (car) parking as well?
There was a problem hiding this comment.
Yes, per: https://github.com/pnorman/vector-datasource/blob/5cd439892d50b0e8a70205f1d3f3597b4515199b/yaml/pois.yaml#L1349-L1377, please add to parking POIs YAML section:
access: {col: access}
operator: {col: operator}
capacity: {col: tags->capacity}
covered:
case:
- when:
covered: 'yes'
then: true
- when:
covered: 'no'
then: false
fee:
case:
- when:
fee: true
not:
fee: ['no', 'Free', 'free', '0', 'No', 'none']
then: true
# TODO tests expect this to be false and not omitted, is that what we want?
- else: false
maxstay: {col: tags->maxstay}
surveillance:
case:
- when:
surveillance: true
not:
surveillance: ['no', 'none']
then: true
(Which is the same as the others except omitting the cyclcehire id lines, so could be made into a global.)
nvkelso
requested changes
Dec 21, 2017
nvkelso
approved these changes
Feb 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1425.
I tried to pick zoom levels and places within the file similar to similar existing features (e.g. nightclubs like bars)