Update to use new WOF domain #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvkelso
reviewed
Apr 17, 2018
docs/attribution.md
Outdated
|
|
||
| ``` | ||
| Data from Who's On First. <a href="https://whosonfirst.mapzen.com#License">License</a> | ||
| Data from Who's On First. <a href="https://www.whosonfirst.org">License</a> |
There was a problem hiding this comment.
This URL is better to link to: https://www.whosonfirst.org/docs/licenses/.
Though this is the ultimate truth: https://github.com/whosonfirst/whosonfirst-sources/blob/master/sources/README.md
nvkelso
reviewed
Apr 17, 2018
docs/data-sources.md
Outdated
| @@ -45,4 +45,4 @@ More details can be found at: http://www.naturalearthdata.com/about/terms-of-use | |||
|
|
|||
| `source:whosonfirst` | |||
|
|
|||
| [Who's On First](http://whosonfirst.mapzen.com) is Mapzen's place gazetteer, and is used to source neighbourhood labels. | |||
| [Who's On First](http://www.whosonfirst.org/) is an open place gazetteer created by Mapzen and is used to source neighbourhood labels. | |||
|
We also need to update RAWR Tiles generation: |
|
From tilezen/raw_tiles#21 (comment); we probably need to update tilequeue as well: |
nvkelso
approved these changes
Apr 20, 2018
|
With the tilequeue change in I re-ran the CI and it passes! Merging :) |
|
Thanks for re-running! |
zerebubuth
added a commit
to tilezen/tileops
that referenced
this pull request
May 15, 2018
Should be `whosonfirst.org` to match changes made in tilezen/vector-datasource#1489 and tilezen/tilequeue#333. This was causing occasional errors, since tilequeue no longer understands the previous `whosonfirst.mapzen.com` value and raises an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1488.