Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include buffered land at zooms it's not used in #1699

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

zerebubuth
Copy link
Member

The admin boundaries processing only starts at zoom 8, so at best it would be superfluous to include buffered land before that. As it turns out, this meant we were including the buffered land polygons in the output tiles at all lower zooms.

This drastically reduces the size of the boundaries layer for low zoom tiles:

Zoom X Y Size before (bytes) Size after (bytes) Size reduction
6 18 24 5,599 1,653 70%
5 9 12 6,964 1,585 77%
4 4 6 22,244 9,195 59%
3 2 3 53,328 6,446 88%
2 1 1 102,871 13,097 87%
1 0 0 148,128 20,722 86%
0 0 0 230,801 10,700 95%

…would be superfluous to include buffered land before that. As it turns out, this meant we were including the buffered land polygons in the output tiles at all lower zooms.
@zerebubuth zerebubuth requested a review from nvkelso October 31, 2018 16:53
@nvkelso
Copy link
Member

nvkelso commented Oct 31, 2018

LGTM but don't we drop buffered land completely in a later transform? Like it should never export in any zoom tiles?

@zerebubuth
Copy link
Member Author

don't we drop buffered land completely in a later transform?

That's the case with the admin areas that we use for country code assignment, but sadly not the case for the buffered land.

@zerebubuth zerebubuth merged commit cfcc47f into master Oct 31, 2018
@zerebubuth zerebubuth deleted the zerebubuth/drop-buffered-land-at-unused-zooms branch October 31, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants