Drop bicycle network and shield text to match style. #1707

zerebubuth · 2018-11-19T12:42:38Z

Drop RCN from 12 down to 0, LCN from 15 down to 0, and any network on track paths from 12 down to zero. These properties inhibit some degree of merging at mid zooms.

Context.

Connects to #1331. (Note that this is one part of many - submitting a PR for each to avoid it becoming unreadably large.)

Drop RCN from 12 down to 0, LCN from 15 down to 0, and any network on track paths from 12 down to zero. These properties inhibit some degree of merging at mid zooms. Context: #1331 (comment)

zerebubuth · 2018-11-19T15:52:44Z

Follow-up: On 12/1206/1540, which is basically Brooklyn, the number of minor_road features is 38% lower after the change. This means a lot more merging is going on. The layer as a whole is 8% smaller.

nvkelso · 2018-11-19T15:58:16Z

Wow, that’s great! Can you stat here the tile so I can take a look, please?

…

On Mon, Nov 19, 2018 at 07:52 Matt Amos ***@***.***> wrote: Follow-up: On 12/1206/1540, which is basically Brooklyn, the number of minor_road features is 38% lower after the change. This means a lot more merging is going on. The layer as a whole is 8% smaller. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#1707 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA0EOy9YYEWv5M51Sp3JFnhIUTssvRqPks5uwtPNgaJpZM4YpB5h> .

zerebubuth · 2018-11-20T13:45:51Z

For the roads layer features, the counts by kind:

Kind	Before	After	Reduction
ferry	6	6
highway	59	59
major_road	570	568	0%
minor_road	313	200	36%
path	322	313	3%
rail	14	14

Which is what we expected: A big reduction in the number of minor_road kind features and some small reductions in other types. This doesn't have such a huge impact on the bytes per feature:

Kind	Type	Before	After	Reduction
ferry	geom_cmds	154	154
ferry	metadata	24	24
ferry	properties	178	178
highway	geom_cmds	2649	2649
highway	metadata	240	240
highway	properties	1451	1422	2%
major_road	geom_cmds	8170	8168	0%
major_road	metadata	2281	2273	0%
major_road	properties	14785	13576	8%
minor_road	geom_cmds	20101	19919	1%
minor_road	metadata	1262	814	35%
minor_road	properties	7240	4000	45%
path	geom_cmds	5671	5652	0%
path	metadata	1291	1255	3%
path	properties	6994	6777	3%
rail	geom_cmds	1201	1201
rail	metadata	59	59
rail	properties	243	243
		73994	68604	7%

Note that nothing has really changed for any highway kind features. The changes in the size of the properties is likely to be due to re-arrangement of the string table, leading to small changes to the length of the varints used to encode the key and value indexes.

For the layer as a whole, including the string table:

	Before	After	Reduction
Features	73994	68604	7%
Metadata	16	16	0%
String Table	12631	12326	2%
TOTAL	86641	80946	7%

(PS: Looks like I got my maths a little wrong before - the reductions are 35% and 7% for the minor roads count and layer size, rather than 38% and 8% - perhaps I summed up the counts and byte sizes together by mistake or something.)

The GeoJSON for the roads layer is here in a gist and it looks like this (coloured by kind, kind_detail and landuse_kind):

nvkelso · 2018-11-27T05:15:26Z

queries.yaml

+      properties:
+        - bicycle_network
+        - bicycle_shield_text
+        - all_bicycle_networks


Dropping all_bicycle_networks and all_bicycle_shield_texts all the time until the max zoom would be best (not limited to just lcn, for any bicycle network).

Dropped in 2f7728a, and cleaned up some of the other logic for dropping all_bicycle_*

nvkelso · 2018-11-27T05:20:23Z

queries.yaml

+      start_zoom: 0
+      end_zoom: 13
+      properties:
+        - bicycle_network


Reviewing https://github.com/tangrams/walkabout-style/blob/gh-pages/layers/bike-interlay.yaml I see that the network IS referenced like bicycle_network: [icn,ncn,rcn] at lower zooms, but rcn is ignored at super low zooms like filter: { bicycle_network: rcn, $zoom: [8,9,10] }:

https://github.com/tangrams/walkabout-style/blob/gh-pages/layers/bike-interlay.yaml#L1788-L1797

So it would be:

okay to drop bicycle_network from 0 to 11 (or is that 10, I get confused) for rcn

okay to drop bicycle_shield_text from 0 to 12 (one more zoom than bicycle_network is dropped) for rcn

see other comment about always dropping the all* variants until the max zoom) even for rcn

I think I've captured this in 324e67f, but would be good to have a check over the tests to make sure the logic is correct.

nvkelso · 2018-11-27T05:28:59Z

queries.yaml

+      start_zoom: 0
+      end_zoom: 16
+      properties:
+        - bicycle_network


It would be more conservative to do:

okay to drop bicycle_network from 0 to 14 (2 less than max zoom) for lcn

okay to drop bicycle_shield_text from 0 to 15 (one more zoom than bicycle_network is dropped) for lcn – they should be available for labeling at zoom 15 like in https://tangrams.github.io/walkabout-style/#15/37.7844/-122.4416

I think I've captured this in 324e67f, but would be good to have a check over the tests to make sure the logic is correct.

nvkelso · 2018-11-27T05:30:47Z

queries.yaml

+    params:
+      source_layer: roads
+      start_zoom: 0
+      end_zoom: 13


For reference this comes from:

https://github.com/tangrams/walkabout-style/blob/gh-pages/layers/bike-interlay.yaml#L569-L573

nvkelso · 2018-11-27T05:31:39Z

queries.yaml

+      end_zoom: 13
+      properties:
+        - bicycle_network
+        - bicycle_shield_text


Should this include the all* variants, too?

This is answering a slightly different question, but: Since 2f7728a, we drop the all_bicycle_* stuff at anything except max zoom, so we don't need to drop it anywhere else - it's already gone.

nvkelso · 2018-11-27T05:35:14Z

Look at the sample GeoJSON file we can probably also drop bicycle until zoom 13:

https://tangrams.github.io/walkabout-style/#13/37.8177/-122.5060

nvkelso

Great work! See a few comments and then I think we're good to go...

…tion is dropped.

nvkelso · 2018-11-27T17:27:11Z

queries.yaml

        - all_walking_networks
        - all_walking_shield_texts
        - all_bus_networks
        - all_bus_shield_texts
+  # drop all_bicycle_* until the max zoom:
+  # https://github.com/tilezen/vector-datasource/pull/1707#discussion_r236522176


See my other comment in the other PR...

https://github.com/tilezen/vector-datasource/pull/1710/files#r236765704

nvkelso

LGTM, though not sure if https://github.com/tilezen/vector-datasource/pull/1707/files#r236767971 applies to this PR or the other one since commits are in both PRs...

nvkelso · 2018-11-27T17:32:08Z

Please also make sure #1707 (comment) is tracked in an issue somewhere.

zerebubuth · 2018-11-28T11:28:06Z

Tracking the bicycle thing in #1713.

Drop bicycle network and shield text to match style.

9efcb8a

Drop RCN from 12 down to 0, LCN from 15 down to 0, and any network on track paths from 12 down to zero. These properties inhibit some degree of merging at mid zooms. Context: #1331 (comment)

zerebubuth requested a review from nvkelso November 19, 2018 12:42

zerebubuth mentioned this pull request Nov 22, 2018

Drop many "detail" tags on minor roads at mid zooms. #1710

Merged

nvkelso reviewed Nov 27, 2018

View reviewed changes

nvkelso requested changes Nov 27, 2018

View reviewed changes

zerebubuth added 2 commits November 27, 2018 13:05

Drop all_bicycle_* until the max zoom, for all network types.

2f7728a

Be more conservative about the zoom levels at which LCN & RCN informa…

324e67f

…tion is dropped.

nvkelso reviewed Nov 27, 2018

View reviewed changes

nvkelso approved these changes Nov 27, 2018

View reviewed changes

zerebubuth merged commit 324e67f into master Nov 28, 2018

zerebubuth mentioned this pull request Nov 28, 2018

Drop bicycle property at mid and low zooms. #1713

Open

zerebubuth deleted the zerebubuth/1331-drop-road-properties branch November 28, 2018 11:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop bicycle network and shield text to match style. #1707

Drop bicycle network and shield text to match style. #1707

zerebubuth commented Nov 19, 2018

zerebubuth commented Nov 19, 2018

nvkelso commented Nov 19, 2018 via email

zerebubuth commented Nov 20, 2018

nvkelso Nov 27, 2018 •

edited

Loading

zerebubuth Nov 27, 2018

nvkelso Nov 27, 2018 •

edited

Loading

zerebubuth Nov 27, 2018

nvkelso Nov 27, 2018 •

edited

Loading

zerebubuth Nov 27, 2018

nvkelso Nov 27, 2018

nvkelso Nov 27, 2018

zerebubuth Nov 27, 2018

nvkelso commented Nov 27, 2018

nvkelso left a comment •

edited

Loading

nvkelso Nov 27, 2018 •

edited

Loading

nvkelso left a comment

nvkelso commented Nov 27, 2018

zerebubuth commented Nov 28, 2018

Drop bicycle network and shield text to match style. #1707

Drop bicycle network and shield text to match style. #1707

Conversation

zerebubuth commented Nov 19, 2018

zerebubuth commented Nov 19, 2018

nvkelso commented Nov 19, 2018 via email

zerebubuth commented Nov 20, 2018

nvkelso Nov 27, 2018 • edited Loading

Choose a reason for hiding this comment

zerebubuth Nov 27, 2018

Choose a reason for hiding this comment

nvkelso Nov 27, 2018 • edited Loading

Choose a reason for hiding this comment

zerebubuth Nov 27, 2018

Choose a reason for hiding this comment

nvkelso Nov 27, 2018 • edited Loading

Choose a reason for hiding this comment

zerebubuth Nov 27, 2018

Choose a reason for hiding this comment

nvkelso Nov 27, 2018

Choose a reason for hiding this comment

nvkelso Nov 27, 2018

Choose a reason for hiding this comment

zerebubuth Nov 27, 2018

Choose a reason for hiding this comment

nvkelso commented Nov 27, 2018

nvkelso left a comment • edited Loading

Choose a reason for hiding this comment

nvkelso Nov 27, 2018 • edited Loading

Choose a reason for hiding this comment

nvkelso left a comment

Choose a reason for hiding this comment

nvkelso commented Nov 27, 2018

zerebubuth commented Nov 28, 2018

nvkelso Nov 27, 2018 •

edited

Loading

nvkelso Nov 27, 2018 •

edited

Loading

nvkelso Nov 27, 2018 •

edited

Loading

nvkelso left a comment •

edited

Loading

nvkelso Nov 27, 2018 •

edited

Loading