Modify zoom bicycle, theatre, water tower #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvkelso
reviewed
Dec 28, 2018
| 'id': 260354461, | ||
| 'kind': 'bicycle', | ||
| # should be in z15 tile, so min_zoom between 15 and 16 | ||
| 'min_zoom': lambda z: 15 <= z < 16, |
nvkelso
reviewed
Dec 28, 2018
| z, x, y, 'pois', { | ||
| 'id': 35115840, | ||
| 'kind': 'theatre', | ||
| 'min_zoom': lambda z: 16 <= z < 17, |
There was a problem hiding this comment.
There's probably more work to do here with respect to building volume or other indicators – as this is one of the more significant theatres in SF. But this is good for now.
nvkelso
deleted the
zerebubuth/1627-modify-zoom-bicycle-theatre-water-tower
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the
min_zoomof bicycle shops and theatres based on area, and water towers based on height.Notes:
Connects to #1627.