Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of bays in the tile to the largest 10. #1866

Merged
merged 2 commits into from
Apr 11, 2019

Conversation

zerebubuth
Copy link
Member

This adds a tile_kind_rank on bays, straits and fjords based on the area of the feature. Labels are only kept if they're in the top 10 for the metatile. For the area around Vancouver, this looks like it keeps enough labels, but they're not so overwhelming any more.

Connects to #1838.

Before

Zoom 8

before_z8

Zoom 9

before_z9

After

Zoom 8

pr_z8

Zoom 9

pr_z9

@zerebubuth zerebubuth requested a review from nvkelso April 10, 2019 16:29
Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

¿is the kind_tile_rank shared between those 3 kinds or separate ranks for each kind?`

@zerebubuth
Copy link
Member Author

¿is the kind_tile_rank shared between those 3 kinds or separate ranks for each kind?

Shared between those 3, since it seemed like the context was "smaller coastal features". We use the same min_zoom calculation for all 3, so it seemed fair to compare them.

Easy to change, if you'd prefer it separate for all 3? I'm not sure how many tiles have significant numbers of more than one of these, so would the limit be 10 each, or 3-4 of each?

@nvkelso
Copy link
Member

nvkelso commented Apr 10, 2019

I think it's fine to share them, the grouping is logically consistent.

Can you add docs that these kinds also have the new kind_tile_rank, please?

@zerebubuth zerebubuth merged commit 072f0b3 into master Apr 11, 2019
@zerebubuth zerebubuth deleted the zerebubuth/1838-too-many-bays branch April 11, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants