Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimate population for null pop OSM places #1993

Closed
wants to merge 14 commits into from

Conversation

nvkelso
Copy link
Member

@nvkelso nvkelso commented Nov 13, 2021

For #1992
Break out filters in landuse.yaml for different localities by whether they have a population listed or not. If they don't, make the min_zoom higher and estimate the population.

  • Update tests

@nvkelso
Copy link
Member Author

nvkelso commented Nov 16, 2021

Over to @travisgrigsby to take this over the finish line.

@tgrigsby-sc tgrigsby-sc force-pushed the nvkelso/1992-osm-place-pop-estimates branch from ccbd3bb to cd0b8f3 Compare November 17, 2021 01:27
@tgrigsby-sc tgrigsby-sc changed the title [WIP] Estimate population for null pop OSM places Estimate population for null pop OSM places Nov 17, 2021
nvkelso and others added 5 commits November 16, 2021 17:50
OSM data is very messy for these

Useful Overpas query:

```
/*
This has been generated by the overpass-turbo wizard.
The original search was:
“place=town and population=*”
*/
[out:json][timeout:250];
// gather results
(
  // query part for: “place=town and population=*”
  node["place"="city"]["population"](if:t["population"]<5000)({{bbox}});
  way["place"="city"]["population"](if:t["population"]<5000)({{bbox}});
  relation["place"="city"]["population"](if:t["population"]<5000)({{bbox}});
  node["place"="town"]["population"](if:t["population"]<5000)({{bbox}});
  way["place"="town"]["population"](if:t["population"]<5000)({{bbox}});
  relation["place"="town"]["population"](if:t["population"]<5000)({{bbox}});
);
// print results
out body;
>;
out skel qt;
```
@nvkelso
Copy link
Member Author

nvkelso commented Nov 17, 2021

Please also update the newly failing tests:

  • 982-remove-unstyled-localities
  • 988-add-population-to-collision-rank

Copy link
Member Author

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic and new tests look good.

Please fix the other 2 related tests and then ready to merge.

Copy link
Contributor

@tgrigsby-sc tgrigsby-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to clean up the unstyledLocalities tests

@nvkelso
Copy link
Member Author

nvkelso commented Dec 2, 2021

Closed in favor of #2013.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants