-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Estimate population for null pop OSM places #1993
Conversation
Over to @travisgrigsby to take this over the finish line. |
ccbd3bb
to
cd0b8f3
Compare
OSM data is very messy for these Useful Overpas query: ``` /* This has been generated by the overpass-turbo wizard. The original search was: “place=town and population=*” */ [out:json][timeout:250]; // gather results ( // query part for: “place=town and population=*” node["place"="city"]["population"](if:t["population"]<5000)({{bbox}}); way["place"="city"]["population"](if:t["population"]<5000)({{bbox}}); relation["place"="city"]["population"](if:t["population"]<5000)({{bbox}}); node["place"="town"]["population"](if:t["population"]<5000)({{bbox}}); way["place"="town"]["population"](if:t["population"]<5000)({{bbox}}); relation["place"="town"]["population"](if:t["population"]<5000)({{bbox}}); ); // print results out body; >; out skel qt; ```
Please also update the newly failing tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic and new tests look good.
Please fix the other 2 related tests and then ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to clean up the unstyledLocalities tests
…ace-pop-estimates
Closed in favor of #2013. |
For #1992
Break out filters in landuse.yaml for different localities by whether they have a population listed or not. If they don't, make the min_zoom higher and estimate the population.