-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disputed feature documentation #2085
Conversation
for more information, see https://pre-commit.ci
docs/disputed-features.md
Outdated
|
||
## Disputed capitals | ||
|
||
Some cities are considered different administrative levels depending on a country's viewpoint. One country may consider a city to be a regional or country capital while a disputant does not. Natural Earth has this information in the `ne_10m_admin_1_label_points_details` table for affected countries in the `FCLASS_XX` columns. Using Wikidata tags, the NE `FCLASS_XX` data is joined to the OSM feature to create output kinds of `regional_capital:xx` or `country_capital:xx` with a true or false value to allow for different rendering options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the populated places Natural Earth theme instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Wikidata ID tags
(add ID)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh you're right. updated
|
||
[out:xml][timeout:25]; | ||
( | ||
rel(9520114); // Extent of Moroccan Claim at Melilla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How brittle is this? How does someone know to add a new relation (and which one) to this list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question we don't have a great answer to at the moment.
In general, the answer is when NE updates, adds, or removes a relation, then this list should follow. No one else (so far) is making disputed relations in quite the same way as us so it will presumably be an active decision to create a new one on our part rather than locate an existing one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address a few nits. Otherwise very easy to follow, great documentation!
…into disputed_feature_documentation # Conflicts: # docs/disputed-features.md
for more information, see https://pre-commit.ci
…ilezen/vector-datasource into disputed_feature_documentation
This adds scripts and documentation needed to utilize our disputed border work.