tiltfile: explicitly mark echo_off as optional (#6370)

fixes #6369 i think there's an underlying starlark bug here, since it's supposed to be marking this as optional implicitly, and the enforcement of optionality seems to be buggy. Signed-off-by: Nick Santos <[email protected]>
tilt-dev · May 6, 2024 · 191178e · 191178e
1 parent 4c4aa24
commit 191178e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/internal/tiltfile/live_update.go b/internal/tiltfile/live_update.go
@@ -169,7 +169,7 @@ func (s *tiltfileState) liveUpdateRun(thread *starlark.Thread, fn *starlark.Buil
 	if err := s.unpackArgs(fn.Name(), args, kwargs,
 		"cmd", &commandVal,
 		"trigger?", &triggers,
-		"echo_off", &echoOff); err != nil {
+		"echo_off?", &echoOff); err != nil {
 		return nil, err
 	}
 

diff --git a/internal/tiltfile/live_update_test.go b/internal/tiltfile/live_update_test.go
@@ -284,6 +284,7 @@ func TestLiveUpdateRunEchoOff(t *testing.T) {
 		{"echoOff True", `echo_off=True`, true},
 		{"echoOff False", `echo_off=False`, false},
 		{"echoOff default", ``, false},
+		{"echoOff default", `[]`, false},
 	} {
 		t.Run(tc.name, func(t *testing.T) {
 			f := newFixture(t)