Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: if no targets for LiveUpdate found, redirect SILENTLY (the user doesn't care about this) #2320

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

maiamcc
Copy link
Contributor

@maiamcc maiamcc commented Oct 10, 2019

Hello @landism, @dbentley,

Please review the following commits I made in branch maiamcc/silent-redirect-live-update:

061f1c4 (2019-10-10 11:21:53 -0400)
engine: if no targets for LiveUpdate found, redirect SILENTLY (the user doesn't care about this)

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@maiamcc maiamcc requested review from dbentley and landism October 10, 2019 15:26
@maiamcc maiamcc merged commit 18af473 into master Oct 10, 2019
@maiamcc maiamcc deleted the maiamcc/silent-redirect-live-update branch October 10, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants