web: switch HUD tests to use react test-utils instead of enzyme #5707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
react-testing-library doesn't have a good way to get the component instance, but this lower-level library does, so we'll just use that for tests that need it. |
lizzthabet
reviewed
Apr 19, 2022
web/src/HUD.test.tsx
Outdated
| const hud = root.find(HUD) | ||
| expect(hud.text()).toEqual(expect.stringContaining("Loading")) | ||
| let root = emptyHUD() | ||
| let rootTree = renderIntoDocument(root) |
There was a problem hiding this comment.
oh! it looks like this may not return the tree. i'm seeing type errors locally and in ci.
There was a problem hiding this comment.
fixed! tbh i don't know why react thinks this returns void
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @lizzthabet,
Please review the following commits I made in branch nicks/reacttesting:
a729e85 (2022-04-19 14:31:46 -0400)
web: switch HUD tests to use react test-utils instead of enzyme
Code review reminders, by giving a LGTM you attest that: