docker: use the CLI library for creating our docker client. #5719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
force-pushed
the
nicks/dockerclient2
branch
from
6b1917e to
f0a0e4e
Compare
|
tested this manually with a DOCKER_HOST="ssh://host" running over a tailscale network and it works well! |
|
oops, hold on, i messed something up |
nicks
force-pushed
the
nicks/dockerclient2
branch
from
f0a0e4e to
6cc2077
Compare
|
ok, should be good now |
nicks
force-pushed
the
nicks/dockerclient2
branch
from
6cc2077 to
cb81e08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @milas, @lizzthabet,
Please review the following commits I made in branch nicks/dockerclient2:
6b1917e (2022-04-22 12:38:47 -0400)
docker: use the CLI library for creating our docker client.
Fixes #4769
Fixes #4878
Code review reminders, by giving a LGTM you attest that: