Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiltfile: improve path argument parsing. Allow docker_build(dockerfile=None). #5756

Merged
merged 1 commit into from
May 2, 2022
Merged

tiltfile: improve path argument parsing. Allow docker_build(dockerfile=None). #5756

merged 1 commit into from
May 2, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented May 2, 2022

Hello @landism, @nicksieger,

Please review the following commits I made in branch nicks/none:

8fd0761 (2022-05-02 16:02:16 -0400)
tiltfile: improve path argument parsing. Allow docker_build(dockerfile=None).
Fixes #5753

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from landism and nicksieger May 2, 2022 20:02
@nicks nicks merged commit c0651f7 into master May 2, 2022
@nicks nicks deleted the nicks/none branch May 2, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landism landism landism approved these changes

@nicksieger nicksieger Awaiting requested review from nicksieger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker_build None arguments
2 participants
@nicks @landism