Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: remove cloud snapshot dialog #5875

Merged
merged 1 commit into from
Jun 24, 2022
Merged

web: remove cloud snapshot dialog #5875

merged 1 commit into from
Jun 24, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented Jun 24, 2022

Hello @milas, @landism,

Please review the following commits I made in branch nicks/cloud2:

dca8d39 (2022-06-24 12:46:34 -0400)
web: remove cloud snapshot dialog

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from landism and milas June 24, 2022 16:46
milas
milas approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the Jest snapshots (not at all confusing 😂) need to be re-generated

@nicks nicks merged commit 993cf0c into master Jun 24, 2022
@nicks nicks deleted the nicks/cloud2 branch June 24, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milas milas milas approved these changes

@landism landism Awaiting requested review from landism

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicks @milas