Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filewatch: fix a bug in error handling #5888

Merged
merged 1 commit into from
Jul 8, 2022
Merged

filewatch: fix a bug in error handling #5888

merged 1 commit into from
Jul 8, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented Jul 8, 2022

Hello @milas,

Please review the following commits I made in branch nicks/issue5887:

4e52d61 (2022-07-08 14:30:56 -0400)
filewatch: fix a bug in error handling
fixes #5887

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from milas July 8, 2022 18:31
@nicks nicks merged commit 6549abe into master Jul 8, 2022
@nicks nicks deleted the nicks/issue5887 branch July 8, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic caused by controller.go:217
2 participants