k8s: the default host (localhost) should get the default port-forwarding behavior #5988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
force-pushed
the
nicks/portfowards
branch
from
465ab8f to
ec2a8a2
Compare
…ing behavior The tiltfile evaluator usually defaults the empty string to "localhost" (because it's the default web host) We want to make sure that this goes down the default kubernetes binding codepath instead of our custom codepath to resolve hostnames. Fixes tilt-dev#5981 Signed-off-by: Nick Santos <[email protected]>
nicks
force-pushed
the
nicks/portfowards
branch
from
ec2a8a2 to
48c8d9f
Compare
nicksieger
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tiltfile evaluator usually defaults the empty string to "localhost" (because it's the default web host)
We want to make sure that this goes down the default kubernetes binding codepath instead of our custom codepath to resolve hostnames.
Fixes #5981
Signed-off-by: Nick Santos [email protected]