Hide duplicate exit code log message

[dnephin]

Implementation of proposal 2 from #6192

Changing a log message from Error to Debug to prevent it from being printed twice.

I tested this with the following resource:

• local - does not appear to run this code path, the error output from a failure has not changed
• local_resource - was printing the error twice, and now only prints it once
• custom_build - was printing the error twice, and now only prints it once
• k8s_custom_deploy - still prints the full command and stdout, not sure if it changed

The call graph looks something like this:

flowchart TD
cmd.Controller.Reconcile --> cmd.Controller.runInternal
cmd.Controller.ForceRun --> cmd.Controller.runInternal
cmd.Controller.runInternal --> 
processExecer.Start --> processExecer.processRun

Loading

runInternal handles the status from processRun by calling processStatuses, which updates CmdStatus.Terminated.

Is there anything else I can do to track down which other functions use the cmd.Controller ? So far it seems like everything still prints the result correctly.

[dnephin]

k8s_custom_deploy is the other one that may use this code path.

[nicks]

LGTM!