mobx and mobx-react should be peer dependencies

[mweststrate]

I think :) See also mobxjs/mobx#1082

I saw double mobx entries in people's module tree which doesn't seem to be correct:

├─ [email protected]
├─ [email protected]
└─ [email protected]
   ├─ [email protected]
   └─ [email protected]

[timarney]

@mweststrate is my understanding of Peer Dependencies correct?

If something is listed under peerDependencies when a user installs that "rewire" those packages will get pulled in as well?

That is to say a user creates an app using CRA - they install react-app-rewired + the mobx rewire (which in turn installs mobx + mobx-react) ... if the user doesn't have those installed.

Also would you recommend for version number ~1.0 ?

https://nodejs.org/en/blog/npm/peer-dependencies/

[mweststrate]

In recent versions peer dependencies will not be installed automatically, but user will be pointed out that he should install them. So hey has to install `react-app-rewired mobx mobx-react`. But it is the only correct thing to do, otherwise he cannot (properly) update mobx versions etc without you releasing a different version from rewired Op do 6 jul. 2017 om 15:44 schreef Tim Arney <[email protected]>:

…

@mweststrate <https://github.com/mweststrate> is my understanding of Peer Dependencies correct? If something is listed under peerDependencies when a user installs that "rewire" those packages will get pulled in as well? That is to say a user creates an app using CRA - they install react-app-rewired + the mobx rewire (which in turn installs mobx + mobx-react) ... if the user doesn't have those installed. Also would you recommend for version number ~1.0 ? https://nodejs.org/en/blog/npm/peer-dependencies/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#51 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABvGhJU3q-KWrcdKQ6HqmrLQnEAEBi4Hks5sLOShgaJpZM4OPj0m> .

[timarney]

Okay updated and passing tests here https://github.com/timarney/mobx-rewire-test

[DonnieWest]

I've not looked into it yet, but I'd assume this is also true for the other packages? ie preact-rewire

[timarney]

@DonnieWest I would say yes the other rewires will need to be updated as well

But it is the only correct thing to do, otherwise he cannot (properly) update mobx versions etc without you releasing a different version from rewired

Note: Any packages that are just adding a babel plugin should be able to use

injectBabelPlugin('transform-decorators-legacy', config)

The MobX package now makes use of it 63d2f60