Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and update endpoints #42

Merged
merged 3 commits into from
Apr 12, 2018
Merged

Conversation

laander
Copy link
Contributor

@laander laander commented Apr 12, 2018

Motivation

New endpoints added:

// Resources
timekit.getResources();
timekit.getResource(data);
timekit.createResource(data);
timekit.updateResource(data);
timekit.resetResourcePassword(data);
timekit.getResourceTimezone(data);

Endpoints changed:

// Now calls [GET] /app instead of [GET] /apps/:slug
timekit.getApp()

Endpoints being deprecated (but still supported for BC):

// Users
timekit.createUser(data)
timekit.getUserInfo()
timekit.updateUser(data)
timekit.resetUserPassword(data)
timekit.getUserTimezone(data)

// Filter collections
timekit.createFindTimeFilterCollection(data)
timekit.getFindTimeFilterCollections()
timekit.updateFindTimeFilterCollection(data)

I'm also restructuring the internals a bit to split it up into multiple files for better overview.

Side-effects/other

Updated link to API reference in Readme

Tests

Updated tests to reflect the new endpoints.

Who should review it

@vistik

@vistik
Copy link
Contributor

vistik commented Apr 12, 2018

🎱

@laander laander merged commit b97218a into master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants