-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projects v2 #44
Projects v2 #44
Conversation
🎱 |
@laander should we consider adding some info about The same question goes to |
timekit.accountGoogleSignup(data, shouldAutoRedirect:Boolean); | ||
timekit.accountSync(data); | ||
timekit.getAccounts() | ||
timekit.accountGoogleSignup({ callback }, shouldAutoRedirect) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about microsoft? does it use the same? should we consider renaming/adding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good point, I hadn't actually considered that. Let me check in the API routes
@Trolzie I have not mentioned in the README on purpose. Although it was public in our API reference at some point, so people don't get any funky ideas and start to use it. If there is a comment about it on http://developers.timekit.io/ , dont you think that would be enough? |
You are right, docs should be where we do this. I just thought that both internally, plus if people inspect, then it is always nice to see a comment like this when I look at the widget method calls:
I know its a bad example, but you know what i mean :D |
@Trolzie I like that, good idea, all add some comments in the code 👍 |
1 similar comment
@Trolzie I like that, good idea, all add some comments in the code 👍 |
swell @laander I'll wait for the next push 💃 |
lookin good 👾 |
Motivation
We're working on a revised Projects model at Timekit that will be more native to the platform. With this also comes an update to our availability engine (successor to FindTime) and Microsoft related endpoints.
Added new endpoints:
Side-effects/other
Also improved the DX of the endpoints list in README so it includes a specification of which object properties you can send in the arguments to the methods.
Tests
Updated tests with new endpoints.
Release dependencies
timekit-io/booking-js#176
Who should review it
@Trolzie @vistik