Add timekit.deleteBooking method #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @donlion ! I'll be merging and releasing it right away 👍 |
|
@donlion Could you please commit and push a dummy change to the branch? CI tests wasn't enabled for forked repos, and in order to trigger it, a new commit needs to be added 🙈 |
|
@laander Will do! 👌 |
donlion
force-pushed
the
add-delete-booking
branch
from
273fc49 to
7b71fe8
Compare
|
@donlion Released in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There was no support for deleting bookings
Design choices
Tried to follow existing patterns
Side-effects/other
Tests
Known issues/limitations
Release dependencies
Who should review it
Someone from Timekit