Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

charts/avalanche: allow setting additional labels #483

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

paulfantom
Copy link
Contributor

What this PR does / why we need it

This PR allows adding custom labels to all objects deployed via avalanche helm chart.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

@paulfantom paulfantom requested a review from a team as a code owner November 2, 2022 09:00
@onprem
Copy link
Contributor

onprem commented Nov 2, 2022

Looks like there is some problem with generated labels, maybe some newline or indentation problem. The generate check is unrelated and failing because we updated the promscale-mixin recently.

@nhudson
Copy link
Contributor

nhudson commented Nov 2, 2022

I created a PR yesterday to fix the CI build issues at least with the promscale-mixin #482. That would have to be merged or added to this PR for them to pass.

Signed-off-by: Paweł Krupa (paulfantom) <[email protected]>
@paulfantom
Copy link
Contributor Author

I rebased it (to fix generate) issues. Linter was erroring due to issues with empty .Values.labels, I added a conditional and it should work now.

@paulfantom paulfantom enabled auto-merge November 2, 2022 09:17
@paulfantom paulfantom merged commit bbc5b89 into timescale:main Nov 2, 2022
@paulfantom paulfantom deleted the avalanche-labels branch November 2, 2022 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants