This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhudson
suggested changes
Jan 23, 2023
nhudson
suggested changes
Jan 25, 2023
jleni
force-pushed
the
feat/patronictl
branch
from
January 25, 2023 16:28
f8acd80
to
296f5e1
Compare
Yes, I just noticed! sorry about that. |
sorry the rebase removed a line. Fixing that now |
nhudson
suggested changes
Jan 25, 2023
nhudson
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution!!
klaus385
pushed a commit
to klaus385/timescaledb-kubernetes
that referenced
this pull request
Apr 26, 2023
* set patronictl config file * bump chart version * revert line removal
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Points patronictl to the correct config file.
This means that people can run the CLI without using
-c /etc/timescaledb/patroni.yaml
Which issue this PR fixes
Minimizes the risk of mistakes such as
#179
#347
#365
#418
Checklist