LibGit2 integration and tracking subdirs of Julia #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
changed the title
|
Think I got it. Added a line ccall((:giterr_clear, :libgit2), Cvoid, ()) # necessary to avoid errors like "the global/xdg file 'attributes' doesn't exist: No such file or directory"before doing |
timholy
force-pushed
the
teh/git
branch
2 times, most recently
from
5c06d0f to
0acd403
Compare
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
- Coverage 91.23% 85.18% -6.06%
==========================================
Files 6 8 +2
Lines 331 378 +47
==========================================
+ Hits 302 322 +20
- Misses 29 56 +27
Continue to review full report at Codecov.
|
timholy
force-pushed
the
teh/git
branch
5 times, most recently
from
8526344 to
9f65139
Compare
|
OK, this seems to be working. For the stdlibs you need JuliaLang/julia#27759. @maleadt, any interest in testing this? I haven't tried an out-of-tree build, and I think you mentioned you had. |
omus
reviewed
Jun 24, 2018
| prefix = subdir[length(repo_path)+2:end] # git-relative path of this subdir | ||
| tree = git_tree(repo, Base.GIT_VERSION_INFO.commit) | ||
| files = Iterators.filter(file->startswith(file, prefix), keys(tree)) | ||
| ccall((:giterr_clear, :libgit2), Cvoid, ()) # necessary to avoid errors like "the global/xdg file 'attributes' doesn't exist: No such file or directory" |
There was a problem hiding this comment.
I'll look into this more but I think this is pointing to a LibGit2 issue.
There was a problem hiding this comment.
Details on the issue have been filed with libgit2. As a fix for the Julia LibGit2 library I've proposed JuliaLang/julia#27763 which should cleanly work around the issue. For now your giterr_clear solution will work just fine.
|
Thanks for taking over! Tracking The REPL is gloriously broken after this: Doesn't seem like it picked up tracking the stdlib: |
|
Hmm, works just fine for me; I used it heavily to develop several recent Julia PRs. (Note that currently this may segfault-on-exit due to JuliaLang/julia#28306.) Not quite sure how to go about debugging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased & extended version of #91 (CC @maleadt). The goal is to provide the means to track both
Core.Compilerand the stdlibs, thus fixing #63.UPDATE: the rest of this post is outdated, but it is retained for posterity
However, I'm encountering a strange LibGit2-related error, and I'm wondering if @omus might have any insights. The issue is that I can't replicate an error if I run what appears to be the same code from the REPL.
Here's the error:
That line is here. Now let's try it manually:
I don't understand what would cause it to work at the REPL and fail in code. Some kind of race condition? I added a
sleepin a random location but that didn't seem to help.