-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a logging framework #163
Conversation
This is primarily for debugging, so that one has a record of the changes made by Revise.
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
- Coverage 88.99% 87.77% -1.22%
==========================================
Files 8 8
Lines 545 548 +3
==========================================
- Hits 485 481 -4
- Misses 60 67 +7
Continue to review full report at Codecov.
|
+1 Would it also be useful to sprinkle some |
OK, I completely restructured this around Base's logging framework---not sure why I rolled my own when that was available. However, I am not sure how to usefully turn on logging using the |
Yeah, that’s a known problem (JuliaLang/julia#25404). You can also control that variable at runtime (via ENV) |
Passed on Appveyor previously, but my AV queue is long (all the Images packages are running). |
This may help catch weird/rare errors. CC @pfitzseb, @vtjnash.