Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blacklist remover #64

Merged
merged 5 commits into from
Jan 15, 2020
Merged

blacklist remover #64

merged 5 commits into from
Jan 15, 2020

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Jan 14, 2020

Fixes #63

timholy
timholy reviewed Jan 15, 2020
View reviewed changes
Copy link
Owner

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! In addition to the other comments,

  • please use 4-space indent
  • a test would be lovely

src/parcel_snoopi.jl Outdated Show resolved Hide resolved
timholy
timholy reviewed Jan 15, 2020
View reviewed changes
src/parcel_snoopi.jl Outdated Show resolved Hide resolved
src/parcel_snoopi.jl Outdated Show resolved Hide resolved
@aminya aminya requested a review from timholy January 15, 2020 09:53
@aminya
Copy link
Contributor Author

aminya commented Jan 15, 2020

Ready to get merged

@timholy timholy merged commit 6c96ca6 into timholy:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timholy timholy Awaiting requested review from timholy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blacklist not working for parcel_snoopi
2 participants
@aminya @timholy