feat(): promise optional success/error msg #179
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
any update on this PR? |
|
Been trying to figure out how to skip error messages in the case of user cancellation, is there anything holding up getting this in? |
src/core/toast.ts
Outdated
| ...opts?.success, | ||
| }); | ||
| if (msgs.success) | ||
| toast.success(resolveValue(msgs.success, p), { |
There was a problem hiding this comment.
The existing ValueOrFunction allows for null as a return value, it also seems reasonable that if a user returns null from the success/error function it could skip the toast. This seems preferable since especially in the case of errors, whether to show an error may itself be conditional on the type of Error raised.
There was a problem hiding this comment.
Agree! Added this behaviour as well.
|
Sorry for the long wait! Made two small changes:
Merging now 👍 |
|
This is now released with |
In some cases there is no success or error msg
eg. redirect after success.