Enable working on docker running on M1 #510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
reviewed
Apr 13, 2023
| @@ -92,7 +92,7 @@ async function ensureInstalled(version) { | |||
| // make the release name for the current platform and the requested version number | |||
| let releaseName = makeReleaseName({ | |||
| platform: os.platform(), | |||
| arch: os.arch(), | |||
| arch: os.arch().replace('arm64', 'aarch_64'), | |||
There was a problem hiding this comment.
Thanks for the fix, but can you move this into makeReleaseName(), where all the totally sensible naming magic happens?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf does not create releases under arm64 architecture, instead aarch_64 postfix is used