Update utils.py

.gitignore

@@ -1,3 +1,4 @@
+ebay.yaml
 timebay.yaml
 build/
 dist/
@@ -12,3 +13,4 @@ ebaysdk.egg-info/
 \.tox
 venv/
 venv*
+\.virtualenvs

ebay.yaml

@@ -0,0 +1,27 @@
+name: ebay_api_config
+
+# Trading API Sandbox - https://www.x.com/developers/ebay/products/trading-api
+api.sandbox.ebay.com:
+    compatability: 719
+    appid: ENTER_YOUR_APPID_HERE
+    certid: ENTER_YOUR_CERTID_HERE
+    devid: ENTER_YOUR_DEVID_HERE
+    token: ENTER_YOUR_TOKEN_HERE
+
+# Trading API - https://www.x.com/developers/ebay/products/trading-api
+api.ebay.com:
+    compatability: 719
+    appid: ENTER_YOUR_APPID_HERE
+    certid: ENTER_YOUR_CERTID_HERE
+    devid: ENTER_YOUR_DEVID_HERE
+    token: ENTER_YOUR_TOKEN_HERE
+
+# Finding API - https://www.x.com/developers/ebay/products/finding-api
+svcs.ebay.com:
+    appid: ENTER_YOUR_APPID_HERE
+    version: 1.0.0
+
+# Shopping API - https://www.x.com/developers/ebay/products/shopping-api
+open.api.ebay.com:
+    appid: ENTER_YOUR_APPID_HERE
+    version: 671

ebaysdk/__init__.py

@@ -9,8 +9,8 @@
 import platform
 import logging
 
-__version__ = '2.1.4'
-Version = __version__  # for backware compatibility
+__version__ = '2.1.5'
+Version = __version__  # for backward compatibility
 
 try:
     from logging import NullHandler

ebaysdk/config.py

@@ -17,8 +17,6 @@ class Config(object):
     """Config Class for all APIs connections
 
     >>> c = Config(domain='api.ebay.com')
-    >>> print(c.file())
-    ebay.yaml
     >>> c.set('fname', 'tim')
     >>> c.get('fname')
     'tim'

ebaysdk/connection.py

@@ -149,7 +149,7 @@ def build_request(self, verb, data, verb_attrs, files=None):
         requestData = self.build_request_data(verb, data, verb_attrs)
         if files:
             del(headers['Content-Type'])
-            if isinstance(requestData, basestring):  # pylint: disable-msg=E0602
+            if isinstance(requestData, str):  # pylint: disable-msg=E0602
                 requestData = {'XMLPayload': requestData}
 
         request = Request(self.method,
@@ -208,6 +208,7 @@ def process_response(self, parse_response=True):
                                  datetime_nodes=self.datetime_nodes,
                                  parse_response=parse_response)
 
+        self.session.close()
         # set for backward compatibility
         self._response_content = self.response.content
 

ebaysdk/finding/__init__.py

@@ -28,7 +28,7 @@ class Connection(BaseConnection):
 
     Doctests:
     >>> f = Connection(config_file=os.environ.get('EBAY_YAML'), debug=False)
-    >>> retval = f.execute('findItemsAdvanced', {'keywords': u'niño'})
+    >>> retval = f.execute('findItemsAdvanced', {'keywords': u'El Niño'})
     >>> error = f.error()
     >>> print(error)
     None
@@ -99,6 +99,7 @@ def __init__(self, **kwargs):
             'finditemsbykeywordsresponse.categoryhistogramcontainer.categoryhistogram',
             'finditemsbyproductresponse.categoryhistogramcontainer.categoryhistogram',
             'finditemsinebaystoresresponse.categoryhistogramcontainer.categoryhistogram',
+            'finditemsinebaystoresresponse.categoryhistogramcontainer.categoryhistogram.childcategoryhistogram',
             'findcompleteditemsresponse.aspecthistogramcontainer.aspect',
             'finditemsadvancedresponse.aspecthistogramcontainer.aspect',
             'finditemsbycategoryresponse.aspecthistogramcontainer.aspect',

ebaysdk/parallel.py

@@ -6,11 +6,14 @@
 Licensed under CDDL 1.0
 '''
 import sys
-if sys.version_info[0] >= 3:
-    raise ImportError('grequests does not work with python3+')
+from ebaysdk.exception import ConnectionError
 
+# pylint: disable=import-error
 import grequests
-from ebaysdk.exception import ConnectionError
+# pylint: enable=import-error
+
+if sys.version_info[0] >= 3:
+    raise ImportError('grequests does not work with python3+')
 
 
 class Parallel(object):

ebaysdk/shopping/__init__.py

@@ -46,7 +46,7 @@ def __init__(self, **kwargs):
         uri           -- API endpoint uri (default: /shopping)
         appid         -- eBay application id
         siteid        -- eBay country site id (default: 0 (US))
-        compatibility -- version number (default: 799)
+        version       -- version number (default: 799)
         https         -- execute of https (default: True)
         proxy_host    -- proxy hostname
         proxy_port    -- proxy port number

ebaysdk/soa/__init__.py

@@ -55,24 +55,6 @@ def load_from_app_config(self, app_config):
     def response_dict(self):
         return self.response.dict()
 
-        '''
-        if self._response_dict:
-            return self._response_dict
-
-        if self._response_content:
-
-            mydict = self.response.dict()
-
-            try:
-                verb = self.verb + 'Response'
-                self._response_dict = mydict['Envelope']['Body'][verb]
-
-            except KeyError:
-                self._response_dict = mydict.get(self.verb + 'Response', mydict)
-
-        return self._response_dict
-        '''
-
     def build_request_headers(self, verb):
         return {
             'Content-Type': self.config.get('content_type'),

ebaysdk/trading/__init__.py

@@ -217,6 +217,7 @@ def __init__(self, **kwargs):
             'getmembermessagesresponse.abstractrequest.outputselector',
             'getmyebaybuyingresponse.abstractrequest.outputselector',
             'getmyebaysellingresponse.abstractrequest.outputselector',
+            'getmyebaysellingresponse.activelist.itemarray.item',
             'getmymessagesresponse.abstractrequest.outputselector',
             'getnotificationpreferencesresponse.abstractrequest.outputselector',
             'getordersresponse.abstractrequest.outputselector',
@@ -681,7 +682,7 @@ def build_request_headers(self, verb):
             "X-EBAY-API-DEV-NAME": self.config.get('devid', ''),
             "X-EBAY-API-APP-NAME": self.config.get('appid', ''),
             "X-EBAY-API-CERT-NAME": self.config.get('certid', ''),
-            "X-EBAY-API-SITEID": self.config.get('siteid', ''),
+            "X-EBAY-API-SITEID": str(self.config.get('siteid', '')),
             "X-EBAY-API-CALL-NAME": self.verb,
             "Content-Type": "text/xml"
         }
@@ -785,7 +786,7 @@ def _get_resp_body_errors(self):
                 .format(eClass=eClass, severity=eSeverity, code=eCode, shortMsg=eShortMsg,
                         longMsg=eLongMsg)
 
-            #from IPython import embed; embed()
+            # from IPython import embed; embed()
 
             if eSeverity == 'Warning':
                 warnings.append(msg)

ebaysdk/utils.py

@@ -86,7 +86,7 @@ def attribute_check(root):
         if '#text' in root:
             value = root['#text']
         if '@attrs' in root:
-            for ak, av in sorted(root.pop('@attrs').items()):
+            for ak, av in sorted(root['@attrs'].items()):
                 attrs.append(str('{0}="{1}"').format(ak, smart_encode(av)))
 
     return attrs, value
@@ -97,9 +97,12 @@ def smart_encode_request_data(value):
         if sys.version_info[0] < 3:
             return value
 
-        return value.encode('utf-8')
+        if isinstance(value, str):
+            return value.encode('utf-8')
+        else:
+            return value
 
-    except UnicodeDecodeError:
+    except UnicodeDecodeError as e:
         return value
 
 
@@ -295,7 +298,7 @@ def getValue(response_dict, *args, **kwargs):
     if len(args) == 1:
         try:
             return h.get('value', None)
-        except:
+        except Exception as e:
             return h
 
     last = args_a.pop()
@@ -307,7 +310,7 @@ def getValue(response_dict, *args, **kwargs):
 
     try:
         return h.get('value', None)
-    except:
+    except Exception as e:
         return h
 
 
@@ -344,6 +347,7 @@ def perftest_dict2xml():
 
     xml = dict2xml(sample_dict)
 
+
 if __name__ == '__main__':
 
     import timeit

samples/finding.py

@@ -31,6 +31,9 @@ def init_options():
     parser.add_option("-a", "--appid",
                       dest="appid", default=None,
                       help="Specifies the eBay application id to use.")
+    parser.add_option("-n", "--domain",
+                      dest="domain", default='svcs.ebay.com',
+                      help="Specifies the eBay domain to use (e.g. svcs.sandbox.ebay.com).")
 
     (opts, args) = parser.parse_args()
     return opts, args
@@ -39,7 +42,7 @@ def init_options():
 def run(opts):
 
     try:
-        api = finding(debug=opts.debug, appid=opts.appid,
+        api = finding(debug=opts.debug, appid=opts.appid, domain=opts.domain,
                       config_file=opts.yaml, warnings=True)
 
         api_request = {
@@ -66,7 +69,7 @@ def run(opts):
 def run_unicode(opts):
 
     try:
-        api = finding(debug=opts.debug, appid=opts.appid,
+        api = finding(debug=opts.debug, appid=opts.appid, domain=opts.domain,
                       config_file=opts.yaml, warnings=True)
 
         api_request = {
@@ -88,7 +91,7 @@ def run_unicode(opts):
 
 def run2(opts):
     try:
-        api = finding(debug=opts.debug, appid=opts.appid,
+        api = finding(debug=opts.debug, appid=opts.appid, domain=opts.domain,
                       config_file=opts.yaml)
 
         response = api.execute('findItemsByProduct',
@@ -103,7 +106,7 @@ def run2(opts):
 
 def run_motors(opts):
     api = finding(siteid='EBAY-MOTOR', debug=opts.debug, appid=opts.appid, config_file=opts.yaml,
-                  warnings=True)
+                  domain=opts.domain, warnings=True)
 
     api.execute('findItemsAdvanced', {
         'keywords': 'tesla',