Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Finding API to use https by default #283

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

johnsliao
Copy link
Contributor

Per the eBay developer announcement, Finding API is Discontinuing Support for HTTP by October 1, 2019. If HTTPS is not used, then all requests to the Finding API will fail.

This change sets the base url for Finding API to use HTTPS by default.

@selected-pixel-jameson
Copy link

@johnsliao Seeing as this hasn't gotten merged yet, do you know how you set the library to use https without changing the default?

Can this be set in the YAML file? Whenever I update the YAML file with a https: True I get an error.

@johnsliao
Copy link
Contributor Author

Set it when you're instantiating a Finding object.

From from samples

usage = "usage: %prog [options]"
parser = OptionParser(usage=usage)

parser.add_option("-d", "--debug",
                  action="store_true", dest="debug", default=False,
                  help="Enabled debugging [default: %default]")
parser.add_option("-y", "--yaml",
                  dest="yaml", default='ebay.yaml',
                  help="Specifies the name of the YAML defaults file. [default: %default]")
parser.add_option("-a", "--appid",
                  dest="appid", default=None,
                  help="Specifies the eBay application id to use.")
parser.add_option("-n", "--domain",
                  dest="domain", default='svcs.ebay.com',
                  help="Specifies the eBay domain to use (e.g. svcs.sandbox.ebay.com).")

(opts, args) = parser.parse_args()

api = finding(debug=opts.debug, appid=opts.appid, domain=opts.domain,
                config_file=opts.yaml, warnings=True, https=True)

@timotheus
Copy link
Owner

Hi - Given https will be forced on Oct 1st, I'll go ahead and merge it now.

@timotheus timotheus merged commit 24cc741 into timotheus:master Sep 5, 2019
timotheus added a commit that referenced this pull request May 17, 2021
Set Finding API to use https by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants