add eslint rule banning the core to import plugin code (elastic#51563) (

elastic#51895)

* add eslint rule banning the core to import plugin code

* Ban importing legacy plugin code in the сore

* fix eslint errors

* core cannot import xpack rule

* regen docs

.eslintrc.js

@@ -350,6 +350,21 @@ module.exports = {
                 ],
                 allowSameFolder: true,
               },
+              {
+                target: ['src/core/**/*'],
+                from: ['x-pack/**/*'],
+                errorMessage: 'OSS cannot import x-pack files.',
+              },
+              {
+                target: ['src/core/**/*'],
+                from: [
+                  'plugins/**/*',
+                  'src/plugins/**/*',
+                  'src/legacy/core_plugins/**/*',
+                  'src/legacy/ui/**/*',
+                ],
+                errorMessage: 'The core cannot depend on any plugins.',
+              },
               {
                 from: ['src/legacy/ui/**/*', 'ui/**/*'],
                 target: [

src/core/public/saved_objects/saved_objects_client.ts

@@ -33,6 +33,7 @@ import {
 import {
   isAutoCreateIndexError,
   showAutoCreateIndexErrorPage,
+  // eslint-disable-next-line @kbn/eslint/no-restricted-paths
 } from '../../../legacy/ui/public/error_auto_create_index/error_auto_create_index';
 import { SimpleSavedObject } from './simple_saved_object';
 import { HttpFetchOptions, HttpServiceBase } from '../http';

src/core/server/legacy/plugins/find_legacy_plugin_specs.ts

@@ -25,6 +25,7 @@ import {
   // @ts-ignore
 } from '../../../../legacy/plugin_discovery/find_plugin_specs.js';
 import { LoggerFactory } from '../../logging';
+// eslint-disable-next-line @kbn/eslint/no-restricted-paths
 import { collectUiExports as collectLegacyUiExports } from '../../../../legacy/ui/ui_exports/collect_ui_exports';
 import { Config } from '../../config';
 

src/core/server/saved_objects/service/lib/filter_utils.test.ts

@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-
+// eslint-disable-next-line @kbn/eslint/no-restricted-paths
 import { esKuery } from '../../../../../plugins/data/server';
 
 import { validateFilterKueryNode, validateConvertFilterToKueryNode } from './filter_utils';

src/core/server/saved_objects/service/lib/filter_utils.ts

@@ -20,6 +20,7 @@
 import { get, set } from 'lodash';
 import { SavedObjectsErrorHelpers } from './errors';
 import { IndexMapping } from '../../mappings';
+// eslint-disable-next-line @kbn/eslint/no-restricted-paths
 import { esKuery } from '../../../../../plugins/data/server';
 
 export const validateConvertFilterToKueryNode = (

src/core/server/saved_objects/service/lib/repository.ts

@@ -18,7 +18,7 @@
  */
 
 import { omit } from 'lodash';
-import { CallCluster } from 'src/legacy/core_plugins/elasticsearch';
+import { APICaller } from '../../../elasticsearch/';
 
 import { getRootPropertiesObjects, IndexMapping } from '../../mappings';
 import { getSearchDsl } from './search_dsl';
@@ -77,12 +77,12 @@ export interface SavedObjectsRepositoryOptions {
   index: string;
   config: Config;
   mappings: IndexMapping;
-  callCluster: CallCluster;
+  callCluster: APICaller;
   schema: SavedObjectsSchema;
   serializer: SavedObjectsSerializer;
   migrator: KibanaMigrator;
   allowedTypes: string[];
-  onBeforeWrite?: (...args: Parameters<CallCluster>) => Promise<void>;
+  onBeforeWrite?: (...args: Parameters<APICaller>) => Promise<void>;
 }
 
 export interface IncrementCounterOptions extends SavedObjectsBaseOptions {
@@ -100,8 +100,9 @@ export class SavedObjectsRepository {
   private _mappings: IndexMapping;
   private _schema: SavedObjectsSchema;
   private _allowedTypes: string[];
-  private _onBeforeWrite: (...args: Parameters<CallCluster>) => Promise<void>;
-  private _unwrappedCallCluster: CallCluster;
+
+  private _onBeforeWrite: (...args: Parameters<APICaller>) => Promise<void>;
+  private _unwrappedCallCluster: APICaller;
   private _serializer: SavedObjectsSerializer;
 
   constructor(options: SavedObjectsRepositoryOptions) {
@@ -136,7 +137,7 @@ export class SavedObjectsRepository {
 
     this._onBeforeWrite = onBeforeWrite;
 
-    this._unwrappedCallCluster = async (...args: Parameters<CallCluster>) => {
+    this._unwrappedCallCluster = async (...args: Parameters<APICaller>) => {
       await migrator.runMigrations();
       return callCluster(...args);
     };
@@ -869,7 +870,7 @@ export class SavedObjectsRepository {
     };
   }
 
-  private async _writeToCluster(...args: Parameters<CallCluster>) {
+  private async _writeToCluster(...args: Parameters<APICaller>) {
     try {
       await this._onBeforeWrite(...args);
       return await this._callCluster(...args);
@@ -878,7 +879,7 @@ export class SavedObjectsRepository {
     }
   }
 
-  private async _callCluster(...args: Parameters<CallCluster>) {
+  private async _callCluster(...args: Parameters<APICaller>) {
     try {
       return await this._unwrappedCallCluster(...args);
     } catch (err) {

src/core/server/saved_objects/service/lib/search_dsl/query_params.ts

@@ -16,6 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+// eslint-disable-next-line @kbn/eslint/no-restricted-paths
 import { esKuery } from '../../../../../../plugins/data/server';
 
 import { getRootPropertiesObjects, IndexMapping } from '../../../mappings';

src/core/server/saved_objects/service/lib/search_dsl/search_dsl.ts

@@ -23,6 +23,7 @@ import { IndexMapping } from '../../../mappings';
 import { SavedObjectsSchema } from '../../../schema';
 import { getQueryParams } from './query_params';
 import { getSortingParams } from './sorting_params';
+// eslint-disable-next-line @kbn/eslint/no-restricted-paths
 import { esKuery } from '../../../../../../plugins/data/server';
 
 interface GetSearchDslOptions {

src/core/server/server.api.md

@@ -6,7 +6,6 @@
 
 import Boom from 'boom';
 import { BulkIndexDocumentsParams } from 'elasticsearch';
-import { CallCluster } from 'src/legacy/core_plugins/elasticsearch';
 import { CatAliasesParams } from 'elasticsearch';
 import { CatAllocationParams } from 'elasticsearch';
 import { CatCommonParams } from 'elasticsearch';

src/core/server/ui_settings/integration_tests/lib/servers.ts

@@ -25,7 +25,7 @@ import {
   TestKibanaUtils,
   TestUtils,
 } from '../../../../../test_utils/kbn_server';
-import { CallCluster } from '../../../../../legacy/core_plugins/elasticsearch';
+import { APICaller } from '../../../elasticsearch/';
 
 let servers: TestUtils;
 let esServer: TestElasticsearchUtils;
@@ -36,7 +36,7 @@ let kbnServer: TestKibanaUtils['kbnServer'];
 interface AllServices {
   kbnServer: TestKibanaUtils['kbnServer'];
   savedObjectsClient: SavedObjectsClientContract;
-  callCluster: CallCluster;
+  callCluster: APICaller;
   uiSettings: IUiSettingsClient;
   deleteKibanaIndex: typeof deleteKibanaIndex;
 }
@@ -61,7 +61,7 @@ export async function startServers() {
   kbnServer = kbn.kbnServer;
 }
 
-async function deleteKibanaIndex(callCluster: CallCluster) {
+async function deleteKibanaIndex(callCluster: APICaller) {
   const kibanaIndices = await callCluster('cat.indices', { index: '.kibana*', format: 'json' });
   const indexNames = kibanaIndices.map((x: any) => x.index);
   if (!indexNames.length) {