General Improvements #263
Open
General Improvements #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing an element of the logo.
…ite actions for the uninstaller and changed output to be more friendly
CreatedBySeb
changed the title
| for file in $DIR/*.icns; do | ||
| replace_app_icon "$file" | ||
| done | ||
|
|
||
| echo | ||
| echo ' All done! Restart your computer.' | ||
| echo " Thanks for installing flat.icns, we hope your enjoy all your lovely new icons!" |
There was a problem hiding this comment.
Typo: ...we hope you'll enjoy all your...
There was a problem hiding this comment.
Thanks, I've fixed it in the next commit, when you're rewriting things over and over early in the morning, your bound to make a couple stupid mistakes :P
| name=$(basename "$app" .app) | ||
| icon="/icons_backup/$name.icns" | ||
| if [ -d "$app" ]; then | ||
| cp -f "$app/Contents/Resources/$name.icns" "/icons_backup/" |
added 10 commits
July 6, 2016 18:13
james21152
approved these changes
Apr 30, 2017
viktorstrate
added a commit
to viktorstrate/flat.icns
that referenced
this pull request
Jul 3, 2017
General Improvements, see tinalatif#263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1: Updated colours on Spotify and Steam icons, and fixed Steam icon missing an element of the logo. I don't have Illustrator, so I had to implement the changes in Inkscape and save them as SVG, but they can be converted back to AI files easily through Illustrator.
Commit 2: Added an uninstaller script, and modified the installer script to perform required actions for the uninstaller to work efficiently. Also made the output a bit nicer.
Commit 3: Fixed a typo from Commit 2