ArtefactResolution: Fix resolution of test modules #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the base module's targets are overridden in the test module, the following exception may occur during artefact resolution: ``` Exception in thread "main" java.util.NoSuchElementException: None.get at scala.None$.get(Option.scala:529) at scala.None$.get(Option.scala:527) at seed.artefact.ArtefactResolution$.$anonfun$runtimeResolution$1(ArtefactResolution.scala:388) at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:238) at scala.collection.immutable.HashMap$HashMap1.foreach(HashMap.scala:234) at scala.collection.immutable.HashMap$HashTrieMap.foreach(HashMap.scala:468) at scala.collection.TraversableLike.map(TraversableLike.scala:238) at scala.collection.TraversableLike.map$(TraversableLike.scala:231) at scala.collection.AbstractTraversable.map(Traversable.scala:108) at seed.artefact.ArtefactResolution$.runtimeResolution(ArtefactResolution.scala:380) at seed.cli.Generate$.ui(Generate.scala:38) at seed.Cli$.main(Cli.scala:392) at seed.Cli.main(Cli.scala) ``` The exception only happens when the test module's targets are a subset of the base module. This regression was introduced in ee2e274.
tindzk
force-pushed
the
bug/test-module-override-targets
branch
from
9df18bb to
3804ee9
Compare
tindzk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArtefactResolution: Fix resolution of test modules
When the base module's targets are overridden in the test module, the
following exception may occur during artefact resolution:
The exception only happens when the test module's targets are a subset
of the base module.
This regression was introduced in ee2e274.