feat(common): move octal function into e2e testing utils

tinesoft · Jul 3, 2022 · b15a616 · b15a616
1 parent 08d6099
commit b15a616
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 18 deletions.
diff --git a/e2e/nx-micronaut-e2e/tests/nx-micronaut.spec.ts b/e2e/nx-micronaut-e2e/tests/nx-micronaut.spec.ts
@@ -6,7 +6,7 @@ import {
   tmpProjPath,
   uniq,
 } from '@nrwl/nx-plugin/testing';
-import { ensureNxProjectWithDeps } from '@nxrocks/common/testing';
+import { ensureNxProjectWithDeps, octal } from '@nxrocks/common/testing';
 
 import { lstatSync } from 'fs';
 
@@ -171,9 +171,4 @@ describe('nx-micronaut e2e', () => {
       expect(project.tags).toEqual(['e2etag', 'e2ePackage']);
     }, 120000);
   });
-
-  function octal(value: string | number): number {
-    if (typeof value === 'string') return parseInt(value, 8);
-    return value;
-  }
 });
diff --git a/e2e/nx-quarkus-e2e/tests/nx-quarkus.test.ts b/e2e/nx-quarkus-e2e/tests/nx-quarkus.test.ts
@@ -6,7 +6,7 @@ import {
   uniq,
   tmpProjPath
 } from '@nrwl/nx-plugin/testing';
-import { ensureNxProjectWithDeps } from '@nxrocks/common/testing';
+import { ensureNxProjectWithDeps, octal } from '@nxrocks/common/testing';
 
 import { lstatSync } from 'fs';
 
@@ -165,9 +165,4 @@ describe('nx-quarkus e2e', () => {
       expect(project.tags).toEqual(['e2etag', 'e2ePackage']);
     }, 200000);
   });
-
-  function octal(value: string | number): number {
-    if (typeof value === 'string') return parseInt(value, 8);
-    return value;
-  }
 });
diff --git a/e2e/nx-spring-boot-e2e/tests/nx-spring-boot.test.ts b/e2e/nx-spring-boot-e2e/tests/nx-spring-boot.test.ts
@@ -7,7 +7,7 @@ import {
   tmpProjPath
 } from '@nrwl/nx-plugin/testing';
 import { names } from '@nrwl/devkit';
-import {ensureNxProjectWithDeps} from '@nxrocks/common/testing';
+import {ensureNxProjectWithDeps, octal} from '@nxrocks/common/testing';
 
 import { lstatSync } from 'fs';
 
@@ -171,9 +171,4 @@ describe('nx-spring-boot e2e', () => {
 
     }, 200000);
   });
-
-  function octal(value: string | number): number {
-    if (typeof value === 'string') return parseInt(value, 8);
-    return value;
-  }
 });
diff --git a/packages/common/src/lib/testing/utils.ts b/packages/common/src/lib/testing/utils.ts
@@ -46,3 +46,9 @@ export async function* syncToAsyncIterable(syncIterable) {
     yield elem;
   }
 }
+
+
+export function octal(value: string | number): number {
+  if (typeof value === 'string') return parseInt(value, 8);
+  return value;
+}