Rename EventBusBuilder.RegisterTransport(...) to AddTransport(...)

tinglesoftware · Jan 10, 2021 · 966d3e9 · 966d3e9
1 parent 1a628af
commit 966d3e9
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 11 deletions.
diff --git a/src/Tingle.EventBus.Transports.Amazon.Kinesis/EventBusBuilderExtensions.cs b/src/Tingle.EventBus.Transports.Amazon.Kinesis/EventBusBuilderExtensions.cs
@@ -59,7 +59,7 @@ public static EventBusBuilder AddAmazonKinesisTransport(this EventBusBuilder bui
             });
 
             // Register the transport
-            builder.RegisterTransport<AmazonKinesisTransport, AmazonKinesisTransportOptions>();
+            builder.AddTransport<AmazonKinesisTransport, AmazonKinesisTransportOptions>();
 
             return builder;
         }

diff --git a/src/Tingle.EventBus.Transports.Amazon.Sqs/EventBusBuilderExtensions.cs b/src/Tingle.EventBus.Transports.Amazon.Sqs/EventBusBuilderExtensions.cs
@@ -56,7 +56,7 @@ public static EventBusBuilder AddAmazonSqsTransport(this EventBusBuilder builder
             });
 
             // register the transport
-            builder.RegisterTransport<AmazonSqsTransport, AmazonSqsTransportOptions>();
+            builder.AddTransport<AmazonSqsTransport, AmazonSqsTransportOptions>();
 
             return builder;
         }

diff --git a/src/Tingle.EventBus.Transports.Azure.EventHubs/EventBusBuilderExtensions.cs b/src/Tingle.EventBus.Transports.Azure.EventHubs/EventBusBuilderExtensions.cs
@@ -27,7 +27,7 @@ public static EventBusBuilder AddAzureEventHubsTransport(this EventBusBuilder bu
             services.AddSingleton<IPostConfigureOptions<AzureEventHubsTransportOptions>, AzureEventHubsPostConfigureOptions>();
 
             // register the transport
-            builder.RegisterTransport<AzureEventHubsTransport, AzureEventHubsTransportOptions>();
+            builder.AddTransport<AzureEventHubsTransport, AzureEventHubsTransportOptions>();
 
             return builder;
         }

diff --git a/src/Tingle.EventBus.Transports.Azure.QueueStorage/EventBusBuilderExtensions.cs b/src/Tingle.EventBus.Transports.Azure.QueueStorage/EventBusBuilderExtensions.cs
@@ -33,7 +33,7 @@ public static EventBusBuilder AddAzureQueueStorageTransport(this EventBusBuilder
             });
 
             // register the transport
-            builder.RegisterTransport<AzureQueueStorageTransport, AzureQueueStorageTransportOptions>();
+            builder.AddTransport<AzureQueueStorageTransport, AzureQueueStorageTransportOptions>();
 
             return builder;
         }

diff --git a/src/Tingle.EventBus.Transports.Azure.ServiceBus/EventBusBuilderExtensions.cs b/src/Tingle.EventBus.Transports.Azure.ServiceBus/EventBusBuilderExtensions.cs
@@ -33,7 +33,7 @@ public static EventBusBuilder AddAzureServiceBusTransport(this EventBusBuilder b
             });
 
             // register the transport
-            builder.RegisterTransport<AzureServiceBusTransport, AzureServiceBusTransportOptions>();
+            builder.AddTransport<AzureServiceBusTransport, AzureServiceBusTransportOptions>();
 
             return builder;
         }

diff --git a/src/Tingle.EventBus.Transports.Kafka/EventBusBuilderExtensions.cs b/src/Tingle.EventBus.Transports.Kafka/EventBusBuilderExtensions.cs
@@ -53,7 +53,7 @@ public static EventBusBuilder AddKafkaTransport(this EventBusBuilder builder, Ac
             });
 
             // register the transport
-            builder.RegisterTransport<KafkaTransport, KafkaTransportOptions>();
+            builder.AddTransport<KafkaTransport, KafkaTransportOptions>();
 
             return builder;
         }

diff --git a/src/Tingle.EventBus.Transports.RabbitMQ/EventBusBuilderExtensions.cs b/src/Tingle.EventBus.Transports.RabbitMQ/EventBusBuilderExtensions.cs
@@ -27,7 +27,7 @@ public static EventBusBuilder AddRabbitMqTransport(this EventBusBuilder builder,
             services.AddSingleton<IPostConfigureOptions<RabbitMqTransportOptions>, RabbitMqPostConfigureOptions>();
 
             // register the transport
-            builder.RegisterTransport<RabbitMqTransport, RabbitMqTransportOptions>();
+            builder.AddTransport<RabbitMqTransport, RabbitMqTransportOptions>();
 
             return builder;
         }

diff --git a/src/Tingle.EventBus/DependencyInjection/EventBusBuilder.cs b/src/Tingle.EventBus/DependencyInjection/EventBusBuilder.cs
@@ -23,8 +23,7 @@ public EventBusBuilder(IServiceCollection services)
         {
             Services = services ?? throw new ArgumentNullException(nameof(services));
 
-            Services.TryAddEnumerable(
-                ServiceDescriptor.Singleton<IPostConfigureOptions<EventBusOptions>, EventBusPostConfigureOptions>());
+            Services.AddSingleton<IPostConfigureOptions<EventBusOptions>, EventBusPostConfigureOptions>();
         }
 
         /// <summary>
@@ -39,6 +38,8 @@ public EventBusBuilder(IServiceCollection services)
         /// <returns></returns>
         public EventBusBuilder Configure(Action<EventBusOptions> configure)
         {
+            if (configure is null) throw new ArgumentNullException(nameof(configure));
+
             Services.Configure(configure);
             return this;
         }
@@ -49,7 +50,7 @@ public EventBusBuilder Configure(Action<EventBusOptions> configure)
         /// <typeparam name="TTransport"></typeparam>
         /// <typeparam name="TOptions"></typeparam>
         /// <returns></returns>
-        public EventBusBuilder RegisterTransport<TTransport, TOptions>()
+        public EventBusBuilder AddTransport<TTransport, TOptions>()
             where TTransport : class, IEventBusTransport
             where TOptions : EventBusTransportOptionsBase
         {
@@ -233,6 +234,8 @@ public EventBusBuilder ConfigureEvent<TEvent>(Action<EventRegistration> configur
 
         internal static string GetTransportName(Type type)
         {
+            if (type is null) throw new ArgumentNullException(nameof(type));
+
             // Ensure the type implements IEventBusTransport
             if (!(typeof(IEventBusTransport).IsAssignableFrom(type)))
             {

diff --git a/src/Tingle.EventBus/Transports/InMemory/EventBusBuilderExtensions.cs b/src/Tingle.EventBus/Transports/InMemory/EventBusBuilderExtensions.cs
@@ -31,7 +31,7 @@ public static EventBusBuilder AddInMemoryTransport(this EventBusBuilder builder,
             services.AddSingleton<SequenceNumberGenerator>();
 
             // register the transport
-            builder.RegisterTransport<InMemoryTransport, InMemoryTransportOptions>();
+            builder.AddTransport<InMemoryTransport, InMemoryTransportOptions>();
 
             return builder;
         }