Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use env vars in Smee instead of CLI flags: #150

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

jacobweinstock
Copy link
Member

@jacobweinstock jacobweinstock commented Dec 6, 2024

Description

This allows an unset value for an env variable to invoke Smee's automatic IP detection to trigger. With CLI flags this automatic IP detection doesnt work.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

This allows an unset value for an env var to invoke
Smee's automatic IP detection to trigger. With CLI
flags this automatic IP detection doesnt work.

Signed-off-by: Jacob Weinstock <[email protected]>
@rahulbabu95
Copy link

Looks good!

@jacobweinstock jacobweinstock merged commit fdf070f into tinkerbell:main Dec 9, 2024
3 checks passed
@jacobweinstock jacobweinstock deleted the smee-flags-to-envs branch December 9, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants