allow annotations on stack nginx service #62
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows choosing an IP, for example. Or getting an SSL cert
Description
This alows adding annotations to the nginx service, like:
Why is this needed
It is sometimes needed to add annotations depending on the configuration of the cluster, like if you want to use kubevip instead of the normal ingress.
Fixes: #
How Has This Been Tested?
I've tried it both with and without annotations, and it works both way, but with annotations for my metallb address-pool, the service gets a BGP address, and not an ARP'd address.
How are existing users impacted? What migration steps/scripts do we need?
This should be transparent, default dict is empty, so no annotations are the default.
Checklist:
I have: