Use network and ISO booting capabilities in latest Workflow spec #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workflow and BMC API specs have changed and the new versions are needed for ISO mounting. Signed-off-by: Jacob Weinstock <[email protected]>
Also, update to latest Workflow spec. This latest spec will handle network and iso booting. It will also toggle the allowPXE field in the Hardware object. Remove using the allowPXE field to track if Hardware is ready. Hardware is ready when the workflow is successful and/or the Hardware has label "v1alpha1.tinkerbell.org/inUse" equal to true. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
bootOptionsto TinkerbellMachine spec. Also, update to the latest Workflow spec. This latest specwill handle network and iso booting. It will also toggle the allowPXE field in the Hardware object.
Remove using the
allowPXEfield to track if Hardware is ready. Hardware is ready when the Workflow is successful and/or the Hardware has the labelv1alpha1.tinkerbell.org/inUseequal to "true".Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: