Default hardware MAC in iso mount workflows #435
+17
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ISO bootmode, the controller required a placeHolder ":macAddress" to be present in the ISOURL which would then later be replaced to the MAC address of the actual hardware during the workflow creation time. Default the logic to append hardware MAC before the ISO file name by default without any placeholder, as we are doing it anyways right now and this slightly alleviates the user experience. Signed-off-by: Rahul Ganesh <[email protected]>
| // The name of the ISO file must have the .iso extension, but the name can be anything. | ||
| // The $IP and $Port should generally point to the IP and Port of the Smee server | ||
| // as this is where the ISO patching endpoint lives. | ||
| // The ":macAddress" is a placeholder for the MAC address of the hardware and | ||
| // should be provided exactly as is: ":macAddress". | ||
| // The controller will append the MAC address of the hardware in the ISO URL |
There was a problem hiding this comment.
This is a good start, thanks. Will you please add why "The controller will append the MAC address" is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For ISO bootmode, the controller required a placeHolder ":macAddress" to be present in the ISOURL which would then later be replaced to the MAC address of the actual hardware during the workflow creation time. Default the logic to append hardware MAC before the ISO file name by default without any placeholder, as we are doing it anyways right now and this slightly alleviates the user experience.
Why is this needed
Improves UX
Fixes: #
How Has This Been Tested?
Built a custom CAPT image, and verified that the macAddress was populated in the workflow object.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: