Fix exposure of locks externally from the grpc server struct #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdoherty4
force-pushed
the
feature/refactor-grpc
branch
from
ebb0029 to
c59fd0a
Compare
Codecov Report
@@ Coverage Diff @@
## main #101 +/- ##
==========================================
- Coverage 42.56% 42.53% -0.03%
==========================================
Files 8 8
Lines 592 583 -9
==========================================
- Hits 252 248 -4
+ Misses 309 304 -5
Partials 31 31
Continue to review full report at Codecov.
|
chrisdoherty4
changed the title
chrisdoherty4
force-pushed
the
feature/refactor-grpc
branch
from
c59fd0a to
acda117
Compare
jacobweinstock
previously approved these changes
May 9, 2022
jacobweinstock
force-pushed
the
feature/refactor-grpc
branch
from
acda117 to
f88fb3f
Compare
chrisdoherty4
dismissed stale reviews from jacobweinstock and micahhausler
via
9e30b58
chrisdoherty4
force-pushed
the
feature/refactor-grpc
branch
from
f88fb3f to
9e30b58
Compare
Signed-off-by: Chris Doherty <[email protected]>
chrisdoherty4
force-pushed
the
feature/refactor-grpc
branch
from
9e30b58 to
f99b1f2
Compare
jacobweinstock
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93 that we originally thought could segfault. The
jsonpackage actually returns an error about an unsupported type.Nonetheless, the issue with lock exposure and management external to an owning struct is dangerous and has been fixed. The endpoint that passed an incorrect type has removed given no-body could've been using it usefully.