Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kubernetes API URL optional #103

Merged
merged 1 commit into from
May 11, 2022

Conversation

micahhausler
Copy link
Contributor

Description

  • Add default container image tag

Signed-off-by: Micah Hausler [email protected]

Why is this needed

  • setting --kubernetes without --kubeconfig is required for in-cluster clients, and setting only a --kubeconfig is also valid.
  • make image should produce an image with a tag without having to specify any arguments

How are existing users impacted? What migration steps/scripts do we need?

N/A

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

* Add default container image tag

Signed-off-by: Micah Hausler <[email protected]>
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #103 (860da1f) into main (17530ef) will decrease coverage by 2.77%.
The diff coverage is 0.00%.

❗ Current head 860da1f differs from pull request most recent head 9862949. Consider uploading reports for the commit 9862949 to get more accurate results

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   42.53%   39.75%   -2.78%     
==========================================
  Files           8        8              
  Lines         583      581       -2     
==========================================
- Hits          248      231      -17     
- Misses        304      317      +13     
- Partials       31       33       +2     
Impacted Files Coverage Δ
hardware/client.go 0.00% <0.00%> (ø)
grpc/server.go 43.67% <0.00%> (-10.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17530ef...9862949. Read the comment docs.

Copy link
Member

@chrisdoherty4 chrisdoherty4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chrisdoherty4 chrisdoherty4 added the ready-to-merge Signal to Mergify to merge the PR. label May 11, 2022
@mergify mergify bot merged commit 538ebe2 into tinkerbell:main May 11, 2022
@micahhausler micahhausler deleted the kubernetes-args branch May 18, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants