Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include boot drive hint in instance struct #104

Merged
merged 2 commits into from
May 12, 2022

Conversation

mikemrm
Copy link
Contributor

@mikemrm mikemrm commented May 11, 2022

Description

boot_drive_hint is a field provided in cacher to hint at which drive
should be used for the boot drive.

This field already is used by boots when building the vmware config,
however is now being used in osie and needs to be exported.

Reference to boots: https://github.com/tinkerbell/boots/blob/c670ca8c03d5e7c4b951cac56724d21331fb7568/client/instance.go#L42

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #104 (489cf5c) into main (538ebe2) will increase coverage by 2.92%.
The diff coverage is n/a.

❗ Current head 489cf5c differs from pull request most recent head acf4530. Consider uploading reports for the commit acf4530 to get more accurate results

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   39.75%   42.68%   +2.92%     
==========================================
  Files           8        8              
  Lines         581      581              
==========================================
+ Hits          231      248      +17     
+ Misses        317      302      -15     
+ Partials       33       31       -2     
Impacted Files Coverage Δ
hardware/export.go 0.00% <ø> (ø)
grpc/server.go 54.43% <0.00%> (+10.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 538ebe2...acf4530. Read the comment docs.

@mikemrm mikemrm force-pushed the add-boot-drive-hint branch from 0dd3052 to 857fc44 Compare May 12, 2022 15:01
mikemrm added 2 commits May 12, 2022 15:50
boot_drive_hint is a field provided in cacher to hint at which drive
should be used for the boot drive.

This field already is used by boots when building the vmware config,
however is now being used in osie and needs to be exported.

Reference to boots: https://github.com/tinkerbell/boots/blob/c670ca8c03d5e7c4b951cac56724d21331fb7568/client/instance.go#L42

Signed-off-by: Mike Mason <[email protected]>
@mikemrm mikemrm force-pushed the add-boot-drive-hint branch from 857fc44 to acf4530 Compare May 12, 2022 15:50
@mikemrm mikemrm added the ready-to-merge Signal to Mergify to merge the PR. label May 12, 2022
@mergify mergify bot merged commit 27db950 into tinkerbell:main May 12, 2022
@mikemrm mikemrm deleted the add-boot-drive-hint branch May 12, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants