Add kubernetes namespace override #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When launching Hegel in Kubernetes it can default, if no Kubeconfig is specified, to using the ServiceAccount configured with the Pod. The ServiceAccount is the same as the Pod deployment namespace and consequently Hegel defaults to reading from its own namespace. This isn't always desirable as users may want to place Hardware in a different namespace and configure the necessary RBAC rules for Hegel to read. Signed-off-by: Chris Doherty <[email protected]>
chrisdoherty4
force-pushed
the
feature/support-kube-namespace-override
branch
from
f6632d3 to
ca88a0f
Compare
Codecov Report
@@ Coverage Diff @@
## main #106 +/- ##
==========================================
- Coverage 43.13% 42.90% -0.23%
==========================================
Files 8 8
Lines 575 578 +3
==========================================
Hits 248 248
- Misses 296 299 +3
Partials 31 31
Continue to review full report at Codecov.
|
chrisdoherty4
changed the title
chrisdoherty4
added
ready-to-merge
jacobweinstock
approved these changes
May 13, 2022
3 tasks
mergify bot
added a commit
to tinkerbell/smee
that referenced
this pull request
May 23, 2022
Add Kubernetes namespace override. See tinkerbell/hegel#106 for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launching Hegel in Kubernetes it can default, if no Kubeconfig is specified, to using the ServiceAccount configured with the Pod. The ServiceAccount is the same as the Pod deployment namespace and consequently Hegel defaults to reading from its own namespace. This isn't always desirable as users may want to place the
Hardwarecustom resource in a different namespace.By defaulting to in-cluster config and requiring an operator to configure RBAC and explicitly set the
--kube-namespaceoverride we have a 'secure and predictable' out of the box deployment model.